Skip to content

Fails to parse when body includes something that looks like a scope with new line #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Otard95 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fails to parse when body includes something that looks like a scope with new line #48

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cec3321
chore: Add failing test
Otard95 Mar 18, 2024
9987b5f
chore: Update test to reflect issue and expected behaviour
Otard95 Mar 19, 2024
b78c515
Update test/parser.js
wesleytodd May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,16 @@ describe('<message>', () => {
assertNodePositions('fix: address major bug\n\nthis is the first line of the body\n\nthis is the second line of body\n\nAuthor: @bcoe\nRefs #392')
})
})
describe('issues', () => {
it('#48 Fails to parse when body includes something that looks like a scope', () => {
const parsed = parser(`fix(foo): some renovate commit\n\nfoo(\n)`)

expect(parsed).to.have.nested.property('children[2].type', 'body')
expect(parsed).to.have.nested.property('children[2].children[0]').to.deep.include({ type: 'text', value: 'foo(' })
expect(parsed).to.have.nested.property('children[2].children[1]').to.deep.include({ type: 'newline', value: '\n' })
expect(parsed).to.have.nested.property('children[2].children[2]').to.deep.include({ type: 'text', value: ')' })
})
})
})

function assertNodePositions (text) {
Expand Down
Loading