Skip to content

cmd-import: proxy org.opencontainers.image.title to summary in meta.json #4291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
travier merged 2 commits into from
Aug 29, 2025
Merged

cmd-import: proxy org.opencontainers.image.title to summary in meta.json #4291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7f19ff
cmd-import: proxy org.opencontainers.image.title to summary in meta.json
jlebon Aug 29, 2025
6a498a9
cmd-list: don't require `dirty` field in coreos.assembler.container-c…
jlebon Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/cmd-import
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ def generate_build_meta(tmp_oci_archive, tmp_oci_manifest, metadata, ostree_comm
'commit': commit,
}

summary = metadata.get('Labels', {}).get('org.opencontainers.image.title')
Copy link
Member

@dustymabe dustymabe Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we populate description too I think it seems more obvious if we were to use that here instead of title.

Suggested change
summary = metadata.get('Labels', {}).get('org.opencontainers.image.title')
summary = metadata.get('Labels', {}).get('org.opencontainers.image.description')

optional, of course.

if summary:
meta['summary'] = summary

# add a reference to ourselves as well
try:
with open('/cosa/coreos-assembler-git.json') as f:
Expand Down
2 changes: 1 addition & 1 deletion src/cmd-list
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def main():
config = git['commit']
if 'branch' in git:
config = f"{git['branch']} ({config[:12]})"
if git['dirty'] != "false":
if git.get('dirty', 'false') != "false":
config += " (dirty)"
print(f" Config: {config}")
if build['id'] in tags:
Expand Down
Loading