Drop fedora-repos-ostree in F44 #4000
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the fedora-repos-ostree package for Fedora 44 and later versions. This is achieved by removing it from the default package list and adding it back conditionally for versions older than F44. The change is logical and correct. I've added one minor suggestion to improve a comment for better clarity.
| include: | ||
| ostree-layers: | ||
| - overlay/50alternatives | ||
| # Drop fedora-repos-ostree in F44 |
There was a problem hiding this comment.
The comment here describes the overall goal, but it can be slightly confusing as the code block that follows includes the package conditionally. A comment that more directly describes the condition would be clearer for future readers.
# Only include fedora-repos-ostree on F43 and older.
|
Seems sane to me. Since we shouldn't be using them anyway it would probably be OK to just stop shipping them now, but phasing it in with the move to F44 would mean any side effects should get ironed out in |
2 participants
This may have other implications. Let's see what CI says.