Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion manifests/fedora-coreos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ conditional-include:
include:
ostree-layers:
- overlay/50alternatives
# Drop fedora-repos-ostree in F44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment here describes the overall goal, but it can be slightly confusing as the code block that follows includes the package conditionally. A comment that more directly describes the condition would be clearer for future readers.

  # Only include fedora-repos-ostree on F43 and older.

- if: releasever < 44
include:
packages:
- fedora-repos-ostree

ostree-layers:
- overlay/15fcos
Expand All @@ -47,7 +52,6 @@ ostree-layers:

packages:
- fedora-release-coreos
- fedora-repos-ostree
# CL ships this.
- moby-engine
# Already pulled in by moby-engine, but let's be explicit. Typhoon uses it.
Expand Down