NO-JIRA: common.yaml: apply dracut fix in postcript#37
NO-JIRA: common.yaml: apply dracut fix in postcript#37joelcapitao merged 2 commits intocoreos:mainfrom
Conversation
|
It's currently failing as the postscript is executed twice 1. the one coming from f-c-c 2. the other one defined here. |
|
@jcapiitao: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
c28028e to
760412c
Compare
|
/test scos-10-build-test-metal |
|
@jcapiitao can we remove the denylist entry for the multipath resilient test as part of this change? |
Right, I forgot about it, I'll amend my PR once TestISO tests fixed on scos-10 (spotted by Adam while monitoring the pipelines) to save CI resources. |
53311bb to
4fa518f
Compare
TestISO tests fixed with #41 |
@dustymabe looks like the dracut patch does not fix the |
hmm. I thought that was the whole point of this backport: |
Hmm Prow seems down currently so I can't check the logs but yeah, that was the goal. Was the error message the same? It's entirely possible that a separate bug has come in since then that needs fixing. |
The backport was working for f-c-c as we were able to drop the same denylist a few weeks ago [1].
[1] coreos/fedora-coreos-config@9a30544 |
Looks like this is happening on first boot. For first boot, we always rely on the But yeah, quite odd. It's not clear why multipathd didn't take ownership of the devices. |
|
I found out that dracut is configuring multipath with dracut set it to |
|
it looks like the default instead of |
4fa518f to
3829382
Compare
I've proposed to apply part of the patch in the postprocess script. [1] https://gitlab.com/redhat/centos-stream/rpms/dracut/-/merge_requests/59 |
|
Hmm, I just realized that for EL9, it's another issue: |
|
Ahh yes, see also the discussions in dracut-ng/dracut-ng#509.
I think we do still need to carry it until it gets backported to 9.6.
This looks like a race. I saw something similar in coreos/fedora-coreos-config#3572, which we decided to fix with coreos/coreos-installer#1677. One way to check if that patch would fix this locally is to try changing the resilient test to swap the |
I'm not sure I understood fully the check method so I took the other path: backporting the coreos-installer patch into current centos c9s branch, scratch build it [1], build SCOS9 with the build in Thank you for the heads-up here, saving me bunch of time ! @dustymabe dunno if you're aware but the rhel10 tests (added in [2]) are failing. [1] https://kojihub.stream.rdu2.redhat.com/koji/taskinfo?taskID=6001337 |
91376f7 to
ff42fe9
Compare
|
/test rhcos-9-build-test-metal |
travier
left a comment
There was a problem hiding this comment.
Ugly but it's a hopefully temporary workaround.
/lgtm
|
Do we have a RHEL bug for the dracut fixes? |
|
/test rhcos-9-build-test-metal |
|
/test rhcos-9-build-test-metal
Hitting the same infra issue again |
Yeah, I tried using
@jlebon wanted to enable multipath user-friendly names c.f coreos/fedora-coreos-tracker#1937 (comment). For Fedora and EL10, the latest shipped dracut NVR contains the commits enabling it. |
1 similar comment
Yeah, I tried using
@jlebon wanted to enable multipath user-friendly names c.f coreos/fedora-coreos-tracker#1937 (comment). For Fedora and EL10, the latest shipped dracut NVR contains the commits enabling it. |
|
/hold |
This is a follow-up of [1], we have to apply the dracut fix here as the new dracut release containing the same fix landed in F42 and EL10 repos. More details in [2][3] [1] coreos/fedora-coreos-config#3588 [2] coreos/fedora-coreos-tracker#1937 [3] https://issues.redhat.com/browse/RHEL-87490
Applying the dracut patch in a postprocess script fixes the test failure for EL10. For EL9, we still have to ignore the tests while awaiting for the new coreos-installer NVR to land in repo. See tracker URL.
ff42fe9 to
e7cea39
Compare
|
/test scos-9-build-test-qemu |
|
/unhold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbtrystram, jcapiitao, jlebon, travier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jcapiitao: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is a follow-up of [1], we have to apply the dracut fix here as the new dracut release containing the same fix is landing in F42 repo. More details in [2].
[1] coreos/fedora-coreos-config#3588
[2] coreos/fedora-coreos-tracker#1937