compose: Support operating unprivileged on registry and oci#5355
Draft
cgwalters wants to merge 1 commit intocoreos:mainfrom
Draft
compose: Support operating unprivileged on registry and oci#5355cgwalters wants to merge 1 commit intocoreos:mainfrom
registry and oci#5355cgwalters wants to merge 1 commit intocoreos:mainfrom
Conversation
Closes: coreos#5324 Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
rust/src/compose.rs:264
- [nitpick] The variant name 'OciOrRegistry' may be ambiguous regarding whether it covers both OCI and registry transports. Consider renaming it to something more descriptive, such as 'UnprivilegedContainer' or similar.
OciOrRegistry,
.github/workflows/ci.yaml:279
- [nitpick] Ensure that 'test-oci.sh' provides adequate coverage for the unprivileged OCI/registry workflow and is maintained alongside changes to the transport handling.
sudo ./test-oci.sh
Member
Author
|
Nah this doesn't handle uid/gid right, it's going to require more work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5324