Update workflows to use the latest image with go 1.24.0 #6637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankrzeminski32
force-pushed
the
update-build-image-new-go-version
branch
3 times, most recently
from
3f6f74e to
a809e59
Compare
|
Hey @yeya24, any idea why this ci/lint job is failing? |
|
You probably also need to dump golangcilint to a version which supports 1.24 |
dankrzeminski32
force-pushed
the
update-build-image-new-go-version
branch
from
9e7e552 to
2416ded
Compare
dankrzeminski32
force-pushed
the
update-build-image-new-go-version
branch
from
27e196b to
8460370
Compare
Thanks! Here is the PR for that upgrade. |
dankrzeminski32
force-pushed
the
update-build-image-new-go-version
branch
from
8460370 to
8977126
Compare
yes, update go.mod go version. Don't see why not. Thanks! |
dankrzeminski32
force-pushed
the
update-build-image-new-go-version
branch
2 times, most recently
from
b526110 to
f76e5bc
Compare
3 tasks
dankrzeminski32
force-pushed
the
update-build-image-new-go-version
branch
from
bcae9f6 to
b7a7f4b
Compare
dankrzeminski32
force-pushed
the
update-build-image-new-go-version
branch
from
b7a7f4b to
0bdbfd2
Compare
Signed-off-by: dankrzeminski32 <[email protected]>
dankrzeminski32
force-pushed
the
update-build-image-new-go-version
branch
from
30b861f to
ac6dbac
Compare
Signed-off-by: dankrzeminski32 <[email protected]>
Signed-off-by: dankrzeminski32 <[email protected]>
dankrzeminski32
force-pushed
the
update-build-image-new-go-version
branch
from
8c1d6a1 to
7832382
Compare
|
Hello @yeya24 @friedrichg, this is ready for review whenever you get the chance. |
yeya24
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all references of the older build image with the new build image that is now on go 1.24.0.
I wasn't sure if the version in
go.modneeds to be updated from 1.23.0 to 1.24.0, hopefully a maintainer can chime in and let me know.master-8508125dais the image that I found in these logs, per the documentation.Fixes #6636
Regarding all the changes to
httpgrpc.ErrorFcalls, please see the section on vet in the 1.24 release notes.