add dynamic gasfee pricing as a signing client option - Feemarket/Osmosis by ertemann · Pull Request #1911 · cosmos/cosmjs

ertemann · 2025-11-18T14:42:32Z

Summary

Adds automatic gas price discovery for chains with dynamic feemarket modules (Osmosis EIP-1559 and Skip feemarket). Instead of manually setting static gas prices, CosmJS can now query current prices from the chain, preventing transaction failures from outdated pricing.

Changes

New feemarket.ts: Query dynamic gas prices from Osmosis EIP-1559 and Skip feemarket modules
Updated clients: SigningStargateClient and SigningCosmWasmClient now support DynamicGasPriceConfig
Refactoring: Extracted calculateFeeForTransaction() helper
Tests: Some unit tests and an end-to-end validation on Osmosis and Neutron testnets

Usage

const client = await SigningStargateClient.connectWithSigner(rpc, signer, {
  gasPrice: {
    denom: "uosmo",
    multiplier: 1.3,
    minGasPrice: GasPrice.fromString("0.0025uosmo"),
    maxGasPrice: GasPrice.fromString("0.1uosmo"),
  }
});

// Gas price queried automatically per transaction
await client.signAndBroadcast(address, messages, "auto");

Features

Graceful fallback to minGasPrice if feemarket query fails
Min/max constraint enforcement with configurable multiplier
backward compatible - existing code unchanged
Automatic chain detection for Osmosis variants

Inspired by Hermes relayer PR #4004.

… eip1559

packages/stargate/src/signingstargateclient.ts

packages/stargate/src/test-feemarket-multichain.mjs

ertemann · 2025-11-18T14:54:53Z

packages/stargate/src/test-feemarket-multichain.mjs

@@ -0,0 +1,278 @@
+#!/usr/bin/env node


Just a complete integration test to validate the PR, can be removed once merged

anywhere this should be housed @webmaster128 ?

No idea to be honest. We don't have example scripts in here usually. For now it can just be there

packages/stargate/src/feemarket.ts

webmaster128

Nice stuff. Some first thoughts here

packages/cosmwasm/src/signingcosmwasmclient.ts

webmaster128 · 2025-11-22T19:03:59Z

packages/stargate/src/feemarket.ts

+  const product = (BigInt(normalizedValue.atomics) * BigInt(multiplierDecimal.atomics)) / factor;
+
+  return Decimal.fromAtomics(product.toString(), fractionalDigits);
+}


This implementation might be correct. But as we do not need decimal math here we can also use float math more or less like this:

const x = value.toFloatApproximation() * multiplier; // the value we want // now convert x to Decimal

Now exactly as the Decimal API is limited but I think you get the idea

do you prefer float math? current impl works and is precise and testable so kept it for now.

Yeah that's fine. The reason I brought it up is you have a float -> Decimal conversion in here which is not necessarily safe:

const multiplierDecimal = Decimal.fromUserInput(multiplier.toString(), fractionalDigits);

As there are many number string representatations which are not supported by the Decimal constructor. E.g.

> a = 1/10**15 1e-15 > typeof a 'number' > a.toString() '1e-15'

I think using https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed gives us better strings in most cases and reduces the likelihood of errors here.

packages/stargate/src/feemarket.ts

packages/stargate/src/feemarket.spec.ts

ertemann · 2025-11-28T13:21:29Z

Thanks for the comments @webmaster128 will resolve remaining issues tomorrow, didnt have time this week yet.

ertemann · 2025-12-14T08:17:39Z

changes made, ready for merge.

packages/stargate/src/feemarket.ts

tsconfig.json

webmaster128 · 2025-12-16T13:18:19Z

The commit cab1af0 contains copies of a lot of dependencies. This is not needed and should not be done. Did you setup git-lfs? See also https://github.com/cosmos/cosmjs/blob/main/HACKING.md#checking-out-code. We need to ensure the code changes in here are separate from those things.

webmaster128 · 2025-12-16T13:53:30Z

The last commit (the uncommitted dependency change) is not needed. See #1922

ertemann · 2025-12-16T14:25:13Z

The commit cab1af0 contains copies of a lot of dependencies. This is not needed and should not be done. Did you setup git-lfs? See also main/HACKING.md#checking-out-code. We need to ensure the code changes in here are separate from those things.

The commits here are simply the result of a yarn install, if that is not correct then id suggest you do it however you want it but I don't see what there is to fix for me.

I have reset the yarn cache to main, with that state i cannot locally build this change.

webmaster128 · 2025-12-16T14:35:57Z

Looks good overall, thank you. I will take care of linting and stuff to make CI happy tomorrow and then merge it

This is the diff from #1911

webmaster128

Alsright cool, thanks.

I habe a follow-up PR in #1926 including your work and a bunch of improvements. I could not use the existing PRs because of all of the cache related changed. I tried but rebasing was impossible. This happens when git-lfs is not set up during the work. Then the cache files change from pointers to full git blobs and this creates a bit mess. Super annoying, I know. But using the .diff it was no problem.

webmaster128 · 2025-12-18T09:05:13Z

packages/cosmwasm/src/signingcosmwasmclient.ts

+      }
+      if (
+        !(gasPriceConfig instanceof GasPrice) &&
+        !("amount" in gasPriceConfig && "denom" in gasPriceConfig)


An object with {amount: "1234", denom: "blub"} was never a valid input. Maybe it worked though. So I'll just change this to an assertion assert(gasPriceConfig instanceof GasPrice).

webmaster128 · 2025-12-18T09:50:08Z

packages/stargate/src/feemarket.ts

+  const product = (BigInt(normalizedValue.atomics) * BigInt(multiplierDecimal.atomics)) / factor;
+
+  return Decimal.fromAtomics(product.toString(), fractionalDigits);
+}


I think using https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed gives us better strings in most cases and reduces the likelihood of errors here.

webmaster128 · 2025-12-18T09:53:54Z

packages/stargate/src/test-feemarket-multichain.mjs

@@ -0,0 +1,278 @@
+#!/usr/bin/env node


No idea to be honest. We don't have example scripts in here usually. For now it can just be there

This is the diff from #1911

ertemann · 2025-12-18T13:10:03Z

thanks for taking it over the line, hadnt worked with committing cache before and the issues it creates.

add dynamic gasfee pricing as an option through feemarket and osmosis…

fe524db

… eip1559

ertemann changed the title ~~add dynamic gasfee pricing as an option through feemarket and osmosis…~~ add dynamic gasfee pricing as a signing client option - Feemarket/Osmosis Nov 18, 2025

ertemann commented Nov 18, 2025

View reviewed changes

packages/stargate/src/signingstargateclient.ts Show resolved Hide resolved

ertemann commented Nov 18, 2025

View reviewed changes

packages/stargate/src/test-feemarket-multichain.mjs Show resolved Hide resolved

ertemann commented Nov 18, 2025

View reviewed changes

ertemann marked this pull request as draft November 18, 2025 15:00

ertemann marked this pull request as ready for review November 18, 2025 20:10

move to proto cosmjs/types style queries/decoding

713f6bb

ertemann force-pushed the add-feemarket-auto branch from 45ed0de to 713f6bb Compare November 18, 2025 20:12

ertemann commented Nov 18, 2025

View reviewed changes

packages/stargate/src/feemarket.ts Show resolved Hide resolved

[autofix.ci] apply automated fixes

d023f11

webmaster128 reviewed Nov 22, 2025

View reviewed changes

github-advanced-security bot found potential problems Nov 22, 2025

View reviewed changes

packages/stargate/src/feemarket.spec.ts Show resolved Hide resolved

packages/stargate/src/feemarket.spec.ts Show resolved Hide resolved

packages/stargate/src/feemarket.spec.ts Show resolved Hide resolved

ertemann added 3 commits December 13, 2025 16:11

Merge branch 'main' into add-feemarket-auto

a70dd6a

merge main and edit implementation

cab1af0

add cache

947c7c7

webmaster128 reviewed Dec 16, 2025

View reviewed changes

packages/stargate/src/feemarket.ts Outdated Show resolved Hide resolved

webmaster128 reviewed Dec 16, 2025

View reviewed changes

tsconfig.json Outdated Show resolved Hide resolved

ertemann added 4 commits December 16, 2025 15:08

undo ts change

bf07f37

reset yarn cache

cde29c6

reset yarn cache

00f9054

reset yarn cache

55ba6c7

webmaster128 added a commit that referenced this pull request Dec 18, 2025

Add feemarket work (by ertemann)

5aaa785

This is the diff from #1911

webmaster128 mentioned this pull request Dec 18, 2025

Add dynamic gas pricing as a signing client option - Feemarket/Osmosis #1926

Merged

webmaster128 reviewed Dec 18, 2025

View reviewed changes

webmaster128 added this to the 0.38 milestone Dec 18, 2025

webmaster128 added a commit that referenced this pull request Dec 18, 2025

Add feemarket work (by ertemann)

e567204

This is the diff from #1911

webmaster128 closed this in #1926 Dec 18, 2025

Conversation

ertemann commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Features

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

webmaster128 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ertemann commented Nov 28, 2025

Uh oh!

ertemann commented Dec 14, 2025

Uh oh!

Uh oh!

Uh oh!

webmaster128 commented Dec 16, 2025

Uh oh!

webmaster128 commented Dec 16, 2025

Uh oh!

ertemann commented Dec 16, 2025

Uh oh!

webmaster128 commented Dec 16, 2025

Uh oh!

webmaster128 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ertemann commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ertemann commented Nov 18, 2025 •

edited

Loading