Add dynamic gas pricing as a signing client option - Feemarket/Osmosis#1926
Merged
webmaster128 merged 9 commits intomainfrom Dec 18, 2025
Merged
Add dynamic gas pricing as a signing client option - Feemarket/Osmosis#1926webmaster128 merged 9 commits intomainfrom
webmaster128 merged 9 commits intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
webmaster128
force-pushed
the
add-feemarket-auto-simon
branch
2 times, most recently
from
66be11e to
706b3bf
Compare
This is the diff from #1911
webmaster128
force-pushed
the
add-feemarket-auto-simon
branch
from
706b3bf to
9123c2d
Compare
webmaster128
commented
Dec 18, 2025
| const normalizedValue = value.adjustFractionalDigits(fractionalDigits); | ||
|
|
||
| // Convert multiplier to Decimal with same fractional digits | ||
| const multiplierDecimal = Decimal.fromUserInput(multiplier.toString(), fractionalDigits); |
Contributor
Author
There was a problem hiding this comment.
I tried multiplier.toFixed(fractionalDigits) but it leads to some inconvenient effekts like this:
> 0.1.toFixed(18)
'0.100000000000000006'
i.e. we swap one problem with another. Maybe it is good enough as-is, assuming users don't put in multiplier values that lead to scientific notation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #1911. Closes #1911