fix(gmp): fix keeper initialization and packet unmarshaling#8660
Merged
srdtrk merged 1 commit intoserdar/xxx-contract-callsfrom Oct 10, 2025
Merged
fix(gmp): fix keeper initialization and packet unmarshaling#8660srdtrk merged 1 commit intoserdar/xxx-contract-callsfrom
srdtrk merged 1 commit intoserdar/xxx-contract-callsfrom
Conversation
Fix two critical bugs in ICS27-GMP module:
1. keeper: Initialize msgRouter and accountKeeper fields that were
being passed to NewKeeper but not assigned to the keeper struct,
causing nil pointer panics when routing messages
2. packet: Fix UnmarshalPacketData to use correct Go unmarshal pattern
by initializing pointer before passing to json.Unmarshal instead of
passing pointer-to-pointer
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## serdar/xxx-contract-calls #8660 +/- ##
============================================================
Coverage ? 56.37%
============================================================
Files ? 335
Lines ? 23605
Branches ? 0
============================================================
Hits ? 13307
Misses ? 9691
Partials ? 607
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
srdtrk
added a commit
that referenced
this pull request
Jan 14, 2026
* feat: added proto types * chore: ran proto-all * chore: generate proto * imp: added type helpers * imp: added new proto * imp: added query.proto * chore: gen proto types * imp: regen proto * imp: save progress * feat: implemented basic module with autocli * imp: added ibc boilerplate * feat: add module to simapp * imp: added account keeper * imp: remoce ics4wrapper * imp: implemented first message server * imp: verify autocli * imp: implemented OnSendPacket * imp: implemented ack and timeout entry points * imp: more boilerplate * imp: added ack to proto * imp: added ack helpers * imp: more boilerplate * feat: added account gen * imp: added cosmos tx * imp: implemented receive * imp: implemented query * lint * imp: added gmp to wasm simapp * style: lint * style: lint * chore: bump go version * imp: attempt to improve module wiring * imp: fix attempt * imp: removed gmp from unused simapp * fix: keeper wiring * imp: allow receiver to be empty * imp: added logger * imp: no err if acc already exists * deps: go mod tidy * fix: compiler problems * imp: allow protojson * imp: added NewMsgSendCall * lint: issues * docs: add PICKUP to gmp * docs: added pickup doc * fix(gmp): fix keeper initialization and packet unmarshaling (#8660) Fix two critical bugs in ICS27-GMP module: 1. keeper: Initialize msgRouter and accountKeeper fields that were being passed to NewKeeper but not assigned to the keeper struct, causing nil pointer panics when routing messages 2. packet: Fix UnmarshalPacketData to use correct Go unmarshal pattern by initializing pointer before passing to json.Unmarshal instead of passing pointer-to-pointer * docs: godocs * imp: added accounts_by_address * chore: update proto * chore: regen proto * chore: implemented query server * imp: added GetAccount * test: add tests for 27-gmp module (#8728) * gmp tests * lint * add codec test * add genesis test * ignore e2e codecov * add tests * add module tests * +test * +test * +tests * +tests * +tests * +tests and bugfix * more tests * add query e2e tests * + test * +genesis tests * update * update * loop * update test * rework tests * imp: gmp packet work PacketDataUnmarshaler/PacketDataProvider (#8730) * PacketDataUnmarshaler and PacketDataProvider for GMP * lint * shorten comment * imp: remove callback key * extend tests * bad merge fix * recursive codecov ignore * simplify codecov ignore --------- Co-authored-by: srdtrk <srdtrk@hotmail.com> * imp: deserialization validation * docs: remove pickup * docs: remove todo * imp: review items * imp: added autocli for missing method * chore: remove unused params * imp: added events * imp: added length validations and better error messages * imp: log message * imp: simplified signer check * chore: added testing to codecov ignore --------- Co-authored-by: johnnylarner <james.richardson.2556@gmail.com> Co-authored-by: Mariusz Żak <mariuszzak21@gmail.com> Co-authored-by: Dmytro Onypko <vaporif@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two critical bugs in ICS27-GMP module:
keeper: Initialize msgRouter and accountKeeper fields that were being passed to NewKeeper but not assigned to the keeper struct, causing nil pointer panics when routing messages
packet: Fix UnmarshalPacketData to use correct Go unmarshal pattern by initializing pointer before passing to json.Unmarshal instead of passing pointer-to-pointer
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.