Skip to content

fix(gmp): fix keeper initialization and packet unmarshaling #8660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srdtrk merged 1 commit into from
Oct 10, 2025
Merged

fix(gmp): fix keeper initialization and packet unmarshaling #8660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions modules/apps/27-gmp/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@ func NewKeeper(

sb := collections.NewSchemaBuilder(storeService)
k := Keeper{
cdc: cdc,
authority: authority,
Accounts: collections.NewMap(sb, types.AccountsKey, "accounts", collections.TripleKeyCodec(collections.StringKey, collections.StringKey, collections.BytesKey), codec.CollValue[types.ICS27Account](cdc)),
cdc: cdc,
msgRouter: msgRouter,
accountKeeper: accountKeeper,
authority: authority,
Accounts: collections.NewMap(sb, types.AccountsKey, "accounts", collections.TripleKeyCodec(collections.StringKey, collections.StringKey, collections.BytesKey), codec.CollValue[types.ICS27Account](cdc)),
}

schema, err := sb.Build()
Expand Down
4 changes: 2 additions & 2 deletions modules/apps/27-gmp/types/packet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,10 @@ func UnmarshalPacketData(bz []byte, ics27Version string, encoding string) (*GMPP
panic("unsupported ics27 version")
}

var data *GMPPacketData
data := &GMPPacketData{}
switch encoding {
case EncodingJSON:
if err := json.Unmarshal(bz, &data); err != nil {
if err := json.Unmarshal(bz, data); err != nil {
return nil, errorsmod.Wrapf(ibcerrors.ErrInvalidType, "failed to unmarshal json packet data: %s", err)
}
case EncodingProtobuf:
Expand Down
Loading