Skip to content

added 2 more tests, second test is a combination of two tests#306

Merged
borrrden merged 8 commits intomainfrom
log_redaction_phase2
Dec 4, 2025
Merged

added 2 more tests, second test is a combination of two tests#306
borrrden merged 8 commits intomainfrom
log_redaction_phase2

Conversation

@vipbhardwaj
Copy link
Contributor

Adds the tests :

  1. test_sgCollect1
  2. test_sgCollect_restApi
  3. test_log_content_verification

from mobile-testkit repo.

The 2nd and 3rd tests are combined together into one test, ie, the 2nd test in the migrated versions.
1st test is a direct migration of the 1st one in the list.

@vipbhardwaj vipbhardwaj requested a review from borrrden November 11, 2025 05:07
@vipbhardwaj vipbhardwaj requested a review from borrrden November 12, 2025 06:39
@vipbhardwaj
Copy link
Contributor Author

In this commit, I actually tried by-passing the ssh way altogether but couldn't since I thought I would try the sg_collect method's upload to have it send it to the machine running the test.
But that didn't work as apparently the upload feature is designed for Couchbase Support integration. It requires specific API and as I thought, I can't just pass the machine's IP to just have the logs uploaded there. Turns out it also needs a ticket number.

So atleast temporarily, we are stuck with the ssh approach till we figure something else out.

@vipbhardwaj
Copy link
Contributor Author

@borrrden here the syncgateway.py file has all the methods that mypy is complaining about, I ran all the mypy checks locally and verified it too, why is it yet failing? Can you have a look at it please?

The mypy test should not be failing the funcs exist in all versions, ie, local and remote of this branch

@borrrden
Copy link
Member

Are you sure you don't have local changes that are not present here?

@vipbhardwaj
Copy link
Contributor Author

Are you sure you don't have local changes that are not present here?

Actually I was wrong, you're right, but no the changes aren't local but rather in #322 , hence this PR awaits that, once that's merged, this is a 2min job to rebase, push, fixed mypy, your approval, and done.
SInce everything else is approved.

But I remembered I have to add the Caddy and Other test's stuff too 😭

@vipbhardwaj
Copy link
Contributor Author

@borrrden requesting re-reviewal since i've added SG upadated funcs and also added Caddy browsing hence making the second possible too.

@vipbhardwaj vipbhardwaj requested a review from borrrden December 4, 2025 11:53
@borrrden borrrden merged commit 73bf293 into main Dec 4, 2025
4 checks passed
@borrrden borrrden deleted the log_redaction_phase2 branch December 4, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants