Update test_filter_removed_access_documents for JS#307
Merged
Conversation
Not checking for the filtered access removed doc notification for JS. Based on the discussion, we will not implement document ended notification for the docs rejected by the pull filter in JS. We may implement it based on demand. From Jens, this feature doesn’t make sense as the rejection from the user’s replication filters shouldn’t be treat as an error. Also it happens on the platform as a side effect due to an error thrown by LiteCore. I have created CBL-7645 for changing the behavior on the other platforms in the future release.
borrrden
approved these changes
Nov 10, 2025
Member
borrrden
left a comment
borrrden
left a comment
There was a problem hiding this comment.
If this is not important, though, why not just remove it for all platforms?
Contributor
Author
|
I made changes by removing it for all platforms. The test spec was updated as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not checking for the filtered access removed doc notification for JS. Based on the discussion, we will not implement document ended notification for the docs rejected by the pull filter in JS. We may implement it based on demand.
From Jens, this feature doesn’t make sense as the rejection from the user’s replication filters shouldn’t be treat as an error. Also it happens on the platform as a side effect due to an error thrown by LiteCore. I have created CBL-7645 for changing the behavior on the other platforms in the future release.