Added 2 tests related to multi Client - single SG replication#325
Merged
vipbhardwaj merged 2 commits intomainfrom Dec 3, 2025
Merged
Added 2 tests related to multi Client - single SG replication#325vipbhardwaj merged 2 commits intomainfrom
vipbhardwaj merged 2 commits intomainfrom
Conversation
borrrden
requested changes
Dec 1, 2025
…ng the tests from old kit had the same issue
RIT3shSapata
approved these changes
Dec 2, 2025
borrrden
approved these changes
Dec 2, 2025
Contributor
Author
|
Thank you for the thorough review @RIT3shSapata and @borrrden , the more the PR backlog thins out, the lesser the divergence would be of I think the issue we are seeing related to the PR's local file version having a diff from main is just positional, as to why, because at say line 'X' has some code globally, ie, in main, before I rebase, the local version of it has some new function at line 'X' since I add it manually.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests come from this specific file and line, and the test below this.
Now I have not added nothing new in the client/sec/cbltest/api directory files, nor have I done anything else in other files.
This is just a plain and simple addition in spec/tests/QE and tests/QE dir.
I've only just used the functions in main, since I have branched off main to this current branch. Hence it can safely be merged to main.