Skip to content

Resolve jest/expect-expect warnings and stabilize flaky app runner test #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmcelhaney merged 3 commits into from
Apr 16, 2026
Merged

Resolve jest/expect-expect warnings and stabilize flaky app runner test #1917

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97f8f7e
Initial plan
Copilot Apr 16, 2026
6e347d3
test: add explicit assertions in raw-http-client helper-driven tests
Copilot Apr 16, 2026
2e2b256
test: stabilize app runner selection assertion by group
Copilot Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/repl/raw-http-client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,8 @@ describe("RawHttpClient", () => {

client.get("/pets");

await capture;
const raw = await capture;
expect(raw).toMatch(/^GET \/pets HTTP\/1\.1/);
// Allow the event loop to flush the client's "data"/"end" socket events so
// that #printResponse (including highlightJson with boolean/null values) runs.
await new Promise((resolve) => setTimeout(resolve, 20));
Expand All @@ -227,7 +228,8 @@ describe("RawHttpClient", () => {

client.get("/pets");

await capture;
const raw = await capture;
expect(raw).toMatch(/^GET \/pets HTTP\/1\.1/);
await new Promise((resolve) => setTimeout(resolve, 20));
});

Expand All @@ -240,7 +242,8 @@ describe("RawHttpClient", () => {

client.get("/status");

await capture;
const raw = await capture;
expect(raw).toMatch(/^GET \/status HTTP\/1\.1/);
await new Promise((resolve) => setTimeout(resolve, 20));
});
});
Loading