Resolve jest/expect-expect warnings and stabilize flaky app runner test#1917
Merged
pmcelhaney merged 3 commits intomainfrom Apr 16, 2026
Merged
Resolve jest/expect-expect warnings and stabilize flaky app runner test#1917pmcelhaney merged 3 commits intomainfrom
jest/expect-expect warnings and stabilize flaky app runner test#1917pmcelhaney merged 3 commits intomainfrom
Conversation
4 tasks
Copilot
AI
changed the title
[WIP] Fix jest/expect-expect warnings in tests
Resolve Apr 16, 2026
jest/expect-expect warnings in helper-driven RawHttpClient tests
pmcelhaney
approved these changes
Apr 16, 2026
pmcelhaney
approved these changes
Apr 16, 2026
Collaborator
|
@copilot fix failing tests |
auto-merge was automatically disabled
April 16, 2026 16:21
Head branch was pushed to by a user without write access
Contributor
Author
Fixed in |
Copilot
AI
changed the title
Resolve
Resolve Apr 16, 2026
jest/expect-expect warnings in helper-driven RawHttpClient testsjest/expect-expect warnings and stabilize flaky app runner test
pmcelhaney
approved these changes
Apr 16, 2026
pmcelhaney
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the
jest/expect-expectwarning sites in helper-driven RawHttpClient tests and also addresses follow-up CI feedback by fixing a flaky unit test intest/app.test.ts.Assertion updates
test/repl/raw-http-client.test.tsto assert captured request lines explicitly.CI follow-up fix
test/app.test.ts(uses the first spec's runner as primary...) to avoid depending on race-prone ordering of async mockedApiRunner.createcalls.v1/v2) and asserts primary runner identity via thev1group.Original Prompt
Resolve
jest/expect-expectwarningsAddress
jest/expect-expectwarnings by adding explicit assertions or using approved assertion patterns for helper-driven tests.Context and motivation
Some tests rely on side-effect or thrown-error pathways that are not always detected by the rule. We should make assertions explicit where practical.
Acceptance criteria
Manual acceptance tests
test/repl/raw-http-client.test.ts, the JSON/invalid-JSON/plain-text helper-driven tests each contain an explicitexpect(...)assertion instead of only awaiting side effects.yarn lintdoes not reportjest/expect-expectwarnings fortest/repl/raw-http-client.test.ts.yarn test --coverage=false test/app.test.tspasses consistently, includinguses the first spec's runner as primary....yarn testpasses the full unit suite without the prior flaky failure intest/app.test.ts.Tasks
jest/expect-expectwarning locations.