-
Notifications
You must be signed in to change notification settings - Fork 39
test: add WebKit browser testing and fix webkit-related issues #6556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: louis-bompart <[email protected]>
|
@copilot Playwright is cool, but what about vitestÉ |
Co-authored-by: louis-bompart <[email protected]>
Good catch! I've added WebKit support to Vitest as well in commit 5595d0b. Both the |
|
Co-authored-by: louis-bompart <[email protected]>
Done in commit d1717eb:
The atomic-default tests will now run on both chromium and webkit in CI, with the Touch-based tests automatically skipped in webkit. |
2af2bc5 to
b13a810
Compare
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts
Outdated
Show resolved
Hide resolved
…omic-search-box.e2e.ts
|
@copilot refresh the PR description/title based on the changes I brought up |
Updated the PR title and description to reflect all changes: New Title: Key updates to description:
|
Enables WebKit testing for both Playwright and Vitest to properly validate issue #6554, with fixes for webkit-specific compatibility issues.
Changes
packages/atomic/playwright.config.ts: Added WebKit project configuration with extended timeout (30s) to handle webkit-specific timing issues. WebKit is now always enabled (not CI-only) for easier toggling via VS Code extension.packages/atomic/vitest.config.js: Added conditional WebKit browser instance foratomic-defaulttest project only (storybook remains Chromium-only)packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts: Addeddescribe.skipIf(server.browser === 'webkit')to skip Touch-based tests in WebKit since the Touch constructor is not supported. Renamed test helper function fromtouchChildtotouchChildProductfor clarity.packages/atomic/src/components/search/result-template-components/quickview-iframe/quickview-iframe.tsx: Fixed iframe race condition where contentDocument is not available until the iframe is connected to the DOMpackages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx: Replaced unsafe use ofinoperator withObject.hasOwnfor better type safetypackages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts: Replaced unsafe use ofinoperator withObject.hasOwnfor better type safetyImplementation
Playwright E2E tests:
Vitest atomic-default tests:
Vitest storybook tests:
Skipping incompatible tests:
Result:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.