test: add WebKit browser testing and fix webkit-related issues

packages/atomic/playwright.config.ts

@@ -35,10 +35,16 @@ export default defineConfig({
     //   name: 'firefox',
     //   use: {...devices['Desktop Firefox'], viewport: DEFAULT_DESKTOP_VIEWPORT},
     // },
-    // {
-    //   name: 'webkit',
-    //   use: {...devices['Desktop Safari'], viewport: DEFAULT_DESKTOP_VIEWPORT},
-    // },
+    {
+      name: 'webkit',
+      use: {
+        ...devices['Desktop Safari'],
+        viewport: DEFAULT_DESKTOP_VIEWPORT,
+      },
+      expect: {
+        timeout: 30 * 1000,
+      },
+    },
   ],
   expect: {
     timeout: 7 * 1000,

packages/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.ts

@@ -229,8 +229,8 @@ export class AtomicCommerceSearchBox
       return;
     }
     if (
-      !('redirectTo' in this.searchBoxState) ||
-      !('afterRedirection' in this.searchBox)
+      !Object.hasOwn(this.searchBoxState, 'redirectTo') ||
+      !Object.hasOwn(this.searchBox, 'afterRedirection')
     ) {
       return;
     }
@@ -306,7 +306,7 @@ export class AtomicCommerceSearchBox
   private isStandaloneSearchBox(
     searchBox: SearchBox | StandaloneSearchBox
   ): searchBox is StandaloneSearchBox {
-    return 'updateRedirectUrl' in searchBox;
+    return Object.hasOwn(searchBox, 'updateRedirectUrl');
   }
 
   private updateBreakpoints = once(() => updateBreakpoints(this));

packages/atomic/src/components/commerce/atomic-product-children/atomic-product-children.spec.ts

@@ -2,6 +2,7 @@ import type {ChildProduct} from '@coveo/headless/commerce';
 import {html} from 'lit';
 import {ifDefined} from 'lit/directives/if-defined.js';
 import {describe, expect, it, vi} from 'vitest';
+import {server} from 'vitest/browser';
 import type {AtomicProduct} from '@/src/components/commerce/atomic-product/atomic-product';
 import {closest} from '@/src/utils/dom-utils';
 import {renderInAtomicProduct} from '@/vitest-utils/testing-helpers/fixtures/atomic/commerce/atomic-product-fixture';
@@ -162,51 +163,54 @@ describe('atomic-product-children', () => {
     });
   });
 
-  describe('when a child product is touched', () => {
-    const touchChild = async () => {
-      const {childProducts} = await renderProductChildren();
-      childProducts[3].dispatchEvent(
-        new TouchEvent('touchstart', {
-          touches: [
-            new Touch({
-              identifier: 0,
-              target: childProducts[3],
-              clientX: 100,
-              clientY: 100,
-              screenX: 100,
-              screenY: 100,
-              pageX: 100,
-              pageY: 100,
-              radiusX: 10,
-              radiusY: 10,
-              rotationAngle: 0,
-              force: 0.5,
-            }),
-          ],
-        })
-      );
-      return childProducts;
-    };
-
-    it('should change the active child product', async () => {
-      const childProducts = await touchChild();
-      await expect
-        .poll(() => childProducts[3])
-        .toHaveClass('box-border rounded border border-primary');
-      await expect
-        .poll(() => childProducts[0])
-        .not.toHaveClass('box-border rounded border border-primary');
-    });
+  describe.skipIf(server.browser === 'webkit')(
+    'when a child product is touched',
+    () => {
+      const touchChildProduct = async () => {
+        const {childProducts} = await renderProductChildren();
+        childProducts[3].dispatchEvent(
+          new TouchEvent('touchstart', {
+            touches: [
+              new Touch({
+                identifier: 0,
+                target: childProducts[3],
+                clientX: 100,
+                clientY: 100,
+                screenX: 100,
+                screenY: 100,
+                pageX: 100,
+                pageY: 100,
+                radiusX: 10,
+                radiusY: 10,
+                rotationAngle: 0,
+                force: 0.5,
+              }),
+            ],
+          })
+        );
+        return childProducts;
+      };
+
+      it('should change the active child product', async () => {
+        const childProducts = await touchChildProduct();
+        await expect
+          .poll(() => childProducts[3])
+          .toHaveClass('box-border rounded border border-primary');
+        await expect
+          .poll(() => childProducts[0])
+          .not.toHaveClass('box-border rounded border border-primary');
+      });
 
-    it('should dispatch the "atomic/selectChildProduct" event', async () => {
-      const dispatchSpy = vi.spyOn(
-        AtomicProductChildren.prototype,
-        'dispatchEvent'
-      );
-      await touchChild();
-      expect(dispatchSpy).toHaveBeenCalled();
-    });
-  });
+      it('should dispatch the "atomic/selectChildProduct" event', async () => {
+        const dispatchSpy = vi.spyOn(
+          AtomicProductChildren.prototype,
+          'dispatchEvent'
+        );
+        await touchChildProduct();
+        expect(dispatchSpy).toHaveBeenCalled();
+      });
+    }
+  );
 
   describe('when a child product is clicked', () => {
     it('should stop propagation if the parent element is an <a> tag', async () => {

packages/atomic/src/components/search/atomic-search-box/atomic-search-box.tsx

@@ -215,7 +215,7 @@ export class AtomicSearchBox implements InitializableComponent<Bindings> {
   private isStandaloneSearchBox(
     searchBox: SearchBox | StandaloneSearchBox
   ): searchBox is StandaloneSearchBox {
-    return 'redirectTo' in searchBox;
+    return Object.hasOwn(searchBox, 'redirectTo');
   }
 
   public initialize() {
@@ -254,8 +254,8 @@ export class AtomicSearchBox implements InitializableComponent<Bindings> {
 
   public componentWillUpdate() {
     if (
-      !('redirectTo' in this.searchBoxState) ||
-      !('afterRedirection' in this.searchBox)
+      !Object.hasOwn(this.searchBoxState, 'redirectTo') ||
+      !Object.hasOwn(this.searchBox, 'afterRedirection')
     ) {
       return;
     }

packages/atomic/src/components/search/atomic-search-box/e2e/atomic-search-box.e2e.ts

@@ -1,7 +1,8 @@
 import {expect, test} from './fixture';
 
 test.describe('default', () => {
-  test.beforeEach(async ({searchBox}) => {
+  test.beforeEach(async ({searchBox, browser}) => {
+    browser;
     await searchBox.load({args: {suggestionTimeout: 5000}});
   });
 

packages/atomic/src/components/search/result-template-components/quickview-iframe/quickview-iframe.tsx

@@ -59,7 +59,7 @@ export const QuickviewIframe: FunctionalComponent<{
   // When a document is written with document.open/document.write/document.close
   // it is not synchronous and the content of the iframe is only available to be queried at the end of the current call stack.
   // This add a "wait" (setTimeout 0) before calling the `onSetIframeRef` from the parent modal quickview
-  const waitForIframeContentToBeWritten = () => {
+  const flushMicrotasks = () => {
     return new Promise((resolve) => setTimeout(resolve));
   };
 
@@ -76,6 +76,10 @@ export const QuickviewIframe: FunctionalComponent<{
           return;
         }
 
+        if(iframeRef.isConnected === false) {
+          await flushMicrotasks();
+        }
+
         const documentWriter = iframeRef.contentDocument;
         if (!documentWriter) {
           if (src) {
@@ -97,7 +101,7 @@ export const QuickviewIframe: FunctionalComponent<{
         writeDocument(documentWriter, content);
         ensureSameResultIsNotOverwritten(documentWriter, uniqueIdentifier);
 
-        await waitForIframeContentToBeWritten();
+        await flushMicrotasks();
         onSetIframeRef(iframeRef);
       }}
     ></iframe>

packages/atomic/vitest.config.js

@@ -113,6 +113,16 @@ const atomicDefault = defineConfig({
             actionTimeout: 3000,
           },
         },
+        ...(process.env.CI
+          ? [
+              {
+                browser: 'webkit',
+                context: {
+                  actionTimeout: 3000,
+                },
+              },
+            ]
+          : []),
       ],
     },
   },