Conversation
anxolin
reviewed
Feb 24, 2025
Contributor
anxolin
left a comment
anxolin
left a comment
There was a problem hiding this comment.
@shoom3301 can you add some context. The description is empty
anxolin
reviewed
Feb 24, 2025
| "0x6f40d4a6237c257fff2db00fa0510deeecd303eb": { | ||
| "type": "eip-2612", | ||
| "version": "1", | ||
| "type": "unsupported", |
Contributor
There was a problem hiding this comment.
I guess this is related to https://cowservices.slack.com/archives/C0361CDG8GP/p1739786487403269, but I didn't get why it was detected as 2612 token, and manually changed later to unsupported
Collaborator
There was a problem hiding this comment.
It's possible their version was updated and/or some other change in their token implementation changed for which the permit script is not able to handle it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.