Skip to content

chore: mark FLUID permit as unsupported #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shoom3301 merged 1 commit into from
Feb 17, 2025
Merged

chore: mark FLUID permit as unsupported #847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/public/PermitInfo.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,8 +740,7 @@
"name": "Nord Token"
},
"0x6f40d4a6237c257fff2db00fa0510deeecd303eb": {
"type": "eip-2612",
"version": "1",
"type": "unsupported",
Copy link
Contributor

@anxolin anxolin Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is related to https://cowservices.slack.com/archives/C0361CDG8GP/p1739786487403269, but I didn't get why it was detected as 2612 token, and manually changed later to unsupported

Copy link
Collaborator

@alfetopito alfetopito Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible their version was updated and/or some other change in their token implementation changed for which the permit script is not able to handle it.

"name": "Instadapp"
},
"0x725c263e32c72ddc3a19bea12c5a0479a81ee688": {
Expand Down Expand Up @@ -7604,4 +7603,4 @@
"type": "unsupported",
"name": "FalconSwap Token"
}
}
}