fix: pty tests skip gracefully when IO::Pty < 1.25#276
Draft
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
fix: pty tests skip gracefully when IO::Pty < 1.25#276toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
Since IPC::Run now requires IO::Pty 1.25 (GH#240), the pty tests
must check the version at plan time instead of just checking that
IO::Pty can be loaded. Without this, systems with IO::Pty 1.21-1.24
get a crash ("process ended prematurely") instead of a clean skip.
Also removes obsolete runtime version warnings for IO::Pty < 1.00,
which are unreachable now that 1.25 is required.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pty tests now check
IO::Pty->VERSION('1.25')at plan time and skip cleanly on older versions.Why
Since IPC::Run requires IO::Pty 1.25 (GH#240), systems with 1.21-1.24 get a crash
(
process ended prematurely) instead of a cleanskip_all. This causes false testfailures in environments where IO::Pty hasn't been updated yet.
How
IO::Pty->VERSION('1.25')check in theBEGINblocks oft/pty.tandt/pty_error_handling.tTesting
🤖 Generated with Claude Code