Skip to content

fix: pty tests skip gracefully when IO::Pty < 1.25 #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
toddr-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: pty tests skip gracefully when IO::Pty < 1.25 #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions t/pty.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,14 @@ BEGIN {
use Test::More;

BEGIN {
if ( eval { require IO::Pty; } ) {
plan tests => 37;
if ( !eval { require IO::Pty; } ) {
plan skip_all => "IO::Pty not installed";
}
elsif ( !eval { IO::Pty->VERSION('1.25'); 1 } ) {
plan skip_all => "IO::Pty >= 1.25 required (have $IO::Pty::VERSION)";
}
else {
plan skip_all => "IO::Pty not installed";
plan tests => 37;
}
}

Expand All @@ -55,27 +58,6 @@ use IPC::Run qw( start pump finish );
select STDERR;
select STDOUT;

sub pty_warn {
warn "\nWARNING: $_[0].\nWARNING: '<pty<', '>pty>' $_[1] not work.\n\n";
}

if ( $^O !~ /Win32/ ) {

# my $min = 0.9;
for ( eval { require IO::Pty; IO::Pty->VERSION } ) {
s/_//g if defined;
if ( !defined ) {
pty_warn "IO::Pty not found", "will";
}
elsif ( $_ == 0.02 ) {
pty_warn "IO::Pty v$_ has spurious warnings, try 0.9 or later", "may";
}
elsif ( $_ < 1.00 ) {
pty_warn "IO::Pty 1.00 is strongly recommended", "may";
}
}
}

diag("IO::Tty $IO::Tty::VERSION, IO::Pty $IO::Pty::VERSION");

my $echoer_script = <<TOHERE;
Expand Down
9 changes: 6 additions & 3 deletions t/pty_error_handling.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,14 @@ BEGIN {
use Test::More;

BEGIN {
if ( eval { require IO::Pty; } ) {
plan tests => 3;
if ( !eval { require IO::Pty; } ) {
plan skip_all => "IO::Pty not installed";
}
elsif ( !eval { IO::Pty->VERSION('1.25'); 1 } ) {
plan skip_all => "IO::Pty >= 1.25 required (have $IO::Pty::VERSION)";
}
else {
plan skip_all => "IO::Pty not installed";
plan tests => 3;
}
}

Expand Down
Loading