Update bin/build_pgms.sh to just use make #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
commented
Nov 2, 2024
jwakely
changed the title
There's no good reason why this script is needed to build with -DNDEBUG and without -g. The performance of the programs is more than adequate even with assert(std::is_sorted(...)) checks in them. Just make this script use 'make clean pgms' so that it doesn't need to be maintained to add new source files, so that the .o files can be reused for multiple programs, and so that it shares the same build flags as the makefile.
Dani-Hub
approved these changes
Nov 2, 2024
Member
Dani-Hub
left a comment
Dani-Hub
left a comment
There was a problem hiding this comment.
Great, looks good! (I'm only using the build_pgms.bat myself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new source file from Tim's #439 changeThere's no good reason why this script is needed to build with -DNDEBUG
and without -g. The performance of the programs is more than adequate
even with assert(std::is_sorted(...)) checks in them.
Just make this script use 'make clean pgms' so that it doesn't need to
be maintained to add new source files, so that the .o files can be
reused for multiple programs, and so that it shares the same build flags
as the makefile.