Skip to content

Conversation

@marcobarilari
Copy link
Collaborator

@marcobarilari marcobarilari commented Mar 5, 2025

Summary by Sourcery

Enhancements:

  • Adds default settings for transparent plots, including color maps and display settings.

@marcobarilari marcobarilari requested a review from Remi-Gau March 5, 2025 12:16
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 5, 2025

Reviewer's Guide by Sourcery

This pull request adds default settings for transparent plots in the defaultResultsStructure.m file. It includes configurations for color maps, opacity, slice orientation, display slices, and figure specifications.

Updated class diagram for defaultResultsStructure

classDiagram
  class defaultResultsStructure {
    +nidm: boolean
    +layers: struct
    +settings: struct
  }

  class layers {
    +color: struct
    +opacity: struct
  }

  class settings {
    +slice: struct
    +fig_specs: struct
  }

  defaultResultsStructure -- layers : has
  defaultResultsStructure -- settings : has
  layers -- settings : uses
Loading

File-Level Changes

Change Details Files
Added default transparent plot settings to the defaultResultsStructure.m file.
  • Added default layers for transparent plots, including color maps and opacity settings.
  • Configured settings for slice orientation, display slices, and figure specifications.
src/defaults/defaultResultsStructure.m

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcobarilari - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider breaking up the large block of code adding the transparent plot defaults into smaller, more manageable functions.
  • It might be helpful to add a comment explaining the purpose of each field in the layers struct.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Remi-Gau and others added 2 commits March 5, 2025 14:28
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (f53979a) to head (c1cd293).
Report is 169 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
+ Coverage   79.57%   81.78%   +2.20%     
==========================================
  Files         285      284       -1     
  Lines        7742     7758      +16     
  Branches       40        0      -40     
==========================================
+ Hits         6161     6345     +184     
+ Misses       1565     1413     -152     
+ Partials       16        0      -16     
Flag Coverage Δ
cli ?
macos-13_matlab-R2023b_fast 63.37% <100.00%> (?)
macos-13_matlab-R2023b_slow 58.72% <100.00%> (?)
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave 76.60% <100.00%> (+0.88%) ⬆️
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?
ubuntu-latest_matlab-R2023b_fast 63.37% <100.00%> (?)
ubuntu-latest_matlab-R2023b_slow 59.21% <100.00%> (?)
windows-latest_matlab-R2023b_fast 63.37% <100.00%> (?)
windows-latest_matlab-R2023b_slow 58.72% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Remi-Gau Remi-Gau merged commit 1ff190f into cpp-lln-lab:main Mar 5, 2025
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants