-
Notifications
You must be signed in to change notification settings - Fork 15
Add defaults for transparent plots #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defaults for transparent plots #1355
Conversation
Reviewer's Guide by SourceryThis pull request adds default settings for transparent plots in the Updated class diagram for defaultResultsStructureclassDiagram
class defaultResultsStructure {
+nidm: boolean
+layers: struct
+settings: struct
}
class layers {
+color: struct
+opacity: struct
}
class settings {
+slice: struct
+fig_specs: struct
}
defaultResultsStructure -- layers : has
defaultResultsStructure -- settings : has
layers -- settings : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marcobarilari - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider breaking up the large block of code adding the transparent plot defaults into smaller, more manageable functions.
- It might be helpful to add a comment explaining the purpose of each field in the
layersstruct.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1355 +/- ##
==========================================
+ Coverage 79.57% 81.78% +2.20%
==========================================
Files 285 284 -1
Lines 7742 7758 +16
Branches 40 0 -40
==========================================
+ Hits 6161 6345 +184
+ Misses 1565 1413 -152
+ Partials 16 0 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
Summary by Sourcery
Enhancements: