fix(ci): use cargo build for dioxus example#411
Merged
FabianLars-crabnebula merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
The dioxus example is a plain desktop app with no dx-specific features. Replace `dx build` with `cargo build --release` so the binary lands in `target/release/` where cargo-packager expects it. This fixes the package CI job on all three platforms: - macOS/Windows: binary now at the expected path - Ubuntu: no longer requires GLIBC 2.38+ from the dx binary Remove the `cargo binstall dioxus-cli` CI step (no longer needed).
Contributor
|
i think getting rid of the cli is good for build times but if we were to keep it (or re-add it later) we could do this |
Contributor
|
Actuallyyyyy, perhaps we should do that since these are examples for users and not just CI? 🤔 |
Contributor
Author
|
Closing this in favour of a proper fix later. After discussion, the right approach here is target-specific packager config (relates to #360) or Will revisit after the current dependency update work is complete. |
Contributor
|
I'm gonna merge this for the time being with a comment inside so the checks are green again. |
FabianLars-crabnebula
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dx build --platform desktop --releasewithcargo build --releasein the dioxus example'sbefore-packaging-commandcargo binstall dioxus-clistep frombuild-examples.yml(no longer needed)Why
The dioxus example is a plain desktop app (20 lines, no manganis assets or dx-specific features).
dx buildoutputs totarget/dx/dioxus-example/release/instead oftarget/release/, causing cargo-packager to fail finding the binary. On Ubuntu 22.04,dxalso requires GLIBC 2.38+ which isn't available.Every other Rust example (wry, egui, slint) already uses
cargo build --release.Test plan
cargo build --release -p dioxus-exampleproduces binary attarget/release/dioxus-example