Revert build-embed option as boolean #784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Revert build-embed option as boolean. Related: php/frankenphp#1651 (comment)
This should not be a bug, but this would be misleading. Although docopt requires options to support space reading, it will cause some confusion according to our habits, especially in other SAPIs
--build-XXXdoes not accept values.But I think it is acceptable to use another option to override the default environment variable (such as
--with-embed-type=shared, if you still feel it is necessary to override it with the command.Otherwise, we consider it a bad practice to encourage others to put all parameters after the extensions.
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.