Fix static linux cli -a not working issue

[crazywhalecc]

What does this PR do?

Fix #888

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

• If you modified *.php or *.json, run them locally to ensure your changes are valid:
  • composer cs-fix
  • composer analyse
  • composer test
  • bin/spc dev:sort-config
• If it's an extension or dependency update, please ensure the following:
  • Add your test combination to src/globals/test-extensions.php.
  • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

[crazywhalecc]

Looks like this function has not been modified 15 years. I don't use CGI but it looks good to merge in php-src. There's no reason not to use inline methods when possible, but I'm not quite sure if this will affect other things, and the official obviously won't apply this update for old PHP version.... So I think we could fix it in SPC individually first. This problem also only occurs in linux full-static builds.

[henderkes]

We can have the patch first, but this should definitely be submitted to php-src. Static musl is likely just not in their CI so they never noticed.

[crazywhalecc]

php/php-src#19746

If accepted in PHP 8.5, we could add version check later. patchFile can ignore patching if contents are totally identical.

[henderkes]

That would be a bug fix that would be backported to 8.1+ I think. But it seems like undefined references cause the builds to fail.

[crazywhalecc]

Seems this change need to let other SAPI depend on cli SAPI if build statically or inline build. I just tested it with the single cli so I didn't find this issues. Maybe it can only be patched with the cli if we don't want to change dependencies.

[crazywhalecc]

Yikes. Keep this PR for now until a better solution is found.

[henderkes]

I'm not a fan of merging it like this. Let's wait what feedback we get from php-src.

[henderkes]

in lack of a response from php-src, we kinda have to do it ourselves temporarily