Skip to content

Conversation

@ramirocruz07
Copy link

@ramirocruz07 ramirocruz07 commented Feb 25, 2025

Fixes

Description

Added shadows to the thumbnail to improve contrast and enhance the card design for better visibility.

Technical details

  • Used CSS box-shadow to create a subtle yet effective shadow around the thumbnail.
  • Ensured responsiveness across different screen sizes.

Tests

  • Verified the shadow effect on multiple screen resolutions.
  • Tested the contrast improvement in both light and dark mode (if applicable).

Screenshots

AFTER
Screenshot 2025-02-25 144346

BEFORE
Screenshot 2025-02-25 144422

Checklist

  • My pull request has a descriptive title.
  • My pull request targets the default branch (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I verified that there are no visible errors after my changes.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Comment on lines +74 to +80
<div class="card">
<div class="card-content">
<img class="thumbnail" src="{{page.image-thumb}}" alt="{% if
page.image-alt %}{{ page.image-alt }} {% else %} '' {% endif %} "
/>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramirocruz07 The indentation does not seem to be right here, you should use prettier for code formatting 🙌

activesupport (7.1.3.2)
base64
bigdecimal
activesupport (6.0.6.1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in Gemfile.lock necessary ? As this is a PR about design, It would be better to restrict the changes to files concerned about that 🙌

end

# Performance-booster for watching directories on Windows
gem "wdm", "~> 0.1.1", :platforms => [:mingw, :x64_mingw, :mswin]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly, the Gemfile should also not be changed

}

.thumbnail {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These blank lines are not needed here, you can format the code with prettier code formatted to avoid these mistakes. there are more formatting issues like in line 82, line 85, etc..

@Murdock9803
Copy link
Member

I am not sure whether the change was needed or not, as we rely on vocabulary for the design scheme of the site. But if its needed, I have left some review comment here 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

2 participants