-
-
Notifications
You must be signed in to change notification settings - Fork 136
Fix : added card design to thumbnail #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| <div class="card"> | ||
| <div class="card-content"> | ||
| <img class="thumbnail" src="{{page.image-thumb}}" alt="{% if | ||
| page.image-alt %}{{ page.image-alt }} {% else %} '' {% endif %} " | ||
| /> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramirocruz07 The indentation does not seem to be right here, you should use prettier for code formatting 🙌
| activesupport (7.1.3.2) | ||
| base64 | ||
| bigdecimal | ||
| activesupport (6.0.6.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the changes in Gemfile.lock necessary ? As this is a PR about design, It would be better to restrict the changes to files concerned about that 🙌
| end | ||
|
|
||
| # Performance-booster for watching directories on Windows | ||
| gem "wdm", "~> 0.1.1", :platforms => [:mingw, :x64_mingw, :mswin] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly, the Gemfile should also not be changed
| } | ||
|
|
||
| .thumbnail { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These blank lines are not needed here, you can format the code with prettier code formatted to avoid these mistakes. there are more formatting issues like in line 82, line 85, etc..
|
I am not sure whether the change was needed or not, as we rely on |
Fixes
Description
Added shadows to the thumbnail to improve contrast and enhance the card design for better visibility.
Technical details
box-shadowto create a subtle yet effective shadow around the thumbnail.Tests
Screenshots
AFTER

BEFORE

Checklist
mainormaster).Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin