Skip to content

Fix : added card design to thumbnail #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramirocruz07 wants to merge 1 commit into
base: main
Choose a base branch
from
+75 −28
Open

Fix : added card design to thumbnail #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,15 @@ platforms :mingw, :x64_mingw, :mswin, :jruby do
end

# Performance-booster for watching directories on Windows
gem "wdm", "~> 0.1.1", :platforms => [:mingw, :x64_mingw, :mswin]
Copy link
Member

@Murdock9803 Murdock9803 Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly, the Gemfile should also not be changed





# Lock `http_parser.rb` gem to `v0.6.x` on JRuby builds since newer versions of the gem
# do not have a Java counterpart.
gem "http_parser.rb", "~> 0.6.0", :platforms => [:jruby]

gem "webrick", "~> 1.7"



45 changes: 19 additions & 26 deletions docs/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,23 @@
GEM
remote: https://rubygems.org/
specs:
activesupport (7.1.3.2)
base64
bigdecimal
activesupport (6.0.6.1)
Copy link
Member

@Murdock9803 Murdock9803 Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in Gemfile.lock necessary ? As this is a PR about design, It would be better to restrict the changes to files concerned about that 🙌

concurrent-ruby (~> 1.0, >= 1.0.2)
connection_pool (>= 2.2.5)
drb
i18n (>= 1.6, < 2)
minitest (>= 5.1)
mutex_m
tzinfo (~> 2.0)
i18n (>= 0.7, < 2)
minitest (~> 5.1)
tzinfo (~> 1.1)
zeitwerk (~> 2.2, >= 2.2.2)
addressable (2.8.6)
public_suffix (>= 2.0.2, < 6.0)
base64 (0.2.0)
bigdecimal (3.1.6)
coffee-script (2.4.1)
coffee-script-source
execjs
coffee-script-source (1.12.2)
colorator (1.1.0)
commonmarker (0.23.10)
concurrent-ruby (1.2.3)
connection_pool (2.4.1)
dnsruby (1.70.0)
simpleidn (~> 0.2.1)
drb (2.2.0)
ruby2_keywords
em-websocket (0.5.3)
eventmachine (>= 0.12.9)
http_parser.rb (~> 0)
Expand All @@ -39,6 +30,7 @@ GEM
faraday-net_http (3.1.0)
net-http
ffi (1.16.3)
ffi (1.16.3-x64-mingw-ucrt)
forwardable-extended (2.6.0)
gemoji (4.1.0)
github-pages (231)
Expand Down Expand Up @@ -215,19 +207,18 @@ GEM
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
mercenary (0.3.6)
mini_portile2 (2.8.8)
minima (2.5.1)
jekyll (>= 3.5, < 5.0)
jekyll-feed (~> 0.9)
jekyll-seo-tag (~> 2.1)
minitest (5.22.2)
mutex_m (0.2.0)
net-http (0.4.1)
uri
nokogiri (1.16.2-aarch64-linux)
racc (~> 1.4)
nokogiri (1.16.2-arm64-darwin)
nokogiri (1.16.2)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.16.2-x86_64-linux)
nokogiri (1.16.2-x64-mingw-ucrt)
racc (~> 1.4)
octokit (4.25.1)
faraday (>= 1, < 3)
Expand All @@ -241,7 +232,6 @@ GEM
ffi (~> 1.0)
rexml (3.2.6)
rouge (3.30.0)
ruby2_keywords (0.0.5)
rubyzip (2.3.2)
safe_yaml (1.0.5)
sass (3.7.4)
Expand All @@ -256,21 +246,25 @@ GEM
unf (~> 0.1.4)
terminal-table (1.8.0)
unicode-display_width (~> 1.1, >= 1.1.1)
thread_safe (0.3.6)
typhoeus (1.4.1)
ethon (>= 0.9.0)
tzinfo (2.0.6)
concurrent-ruby (~> 1.0)
tzinfo (1.2.11)
thread_safe (~> 0.1)
tzinfo-data (1.2025.1)
tzinfo (>= 1.0.0)
unf (0.1.4)
unf_ext
unf_ext (0.0.9.1)
unf_ext (0.0.9.1-x64-mingw-ucrt)
unicode-display_width (1.8.0)
uri (0.13.0)
webrick (1.8.1)
zeitwerk (2.7.2)

PLATFORMS
aarch64-linux
arm64-darwin-23
x86_64-linux-musl
x64-mingw-ucrt
x86_64-linux

DEPENDENCIES
github-pages (~> 231)
Expand All @@ -279,7 +273,6 @@ DEPENDENCIES
minima (~> 2.5)
tzinfo (~> 1.2)
tzinfo-data
wdm (~> 0.1.1)
webrick (~> 1.7)

BUNDLED WITH
Expand Down
47 changes: 46 additions & 1 deletion docs/_assets/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,16 @@ code {
}

.thumbnail {

Copy link
Member

@Murdock9803 Murdock9803 Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These blank lines are not needed here, you can format the code with prettier code formatted to avoid these mistakes. there are more formatting issues like in line 82, line 85, etc..

width: 100%;
aspect-ratio: 200/150;
margin: 0 auto;
}
background-color: var(--card-color);
border-radius: 0.75em;
cursor: pointer;

box-shadow: rgb(38, 57, 77) 0px 20px 30px -10px;
}
.thumbnailtitle {
font-family: "Roboto Condensed";
font-style: normal;
Expand All @@ -92,6 +97,7 @@ code {
font-weight: 400;
}


/* Styles For index.html and all.html */
.filter-grid {
display: grid;
Expand Down Expand Up @@ -316,4 +322,43 @@ footer .donate a {
.thumbnailblurb {
font-size: 5vw;
}


.card {
background-color: var(--card-color);
border-radius: 0.75em;
cursor: pointer;
height: 240px;
position: relative;
}

.card:hover:before {
opacity: 1;
}

.card:before {
background: linear-gradient(
45deg,
transparent 5%,
rgb(255, 215, 137) 50%,
transparent 99%
);
border-radius: inherit;
content: "";
inset: 0px;
opacity: 0;
position: absolute;
transition: opacity 400ms;
z-index: 0;
}

.card-content {
background-color: var(--card-color);
border-radius: inherit;
display: grid;
inset: 1px;
padding: 1em;
position: absolute;
}

}
4 changes: 4 additions & 0 deletions docs/_layouts/listing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,13 @@ <h1>Resources</h1>
class="thumbnailbox {{ page.topic }} {{ page.medium }} {{page.language}}"
>
<article>
<div class="card">
<div class="card-content">
<img class="thumbnail" src="{{page.image-thumb}}" alt="{% if
page.image-alt %}{{ page.image-alt }} {% else %} '' {% endif %} "
/>
</div>
</div>
Comment on lines +74 to +80
Copy link
Member

@Murdock9803 Murdock9803 Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramirocruz07 The indentation does not seem to be right here, you should use prettier for code formatting 🙌

<h3 class="thumbnailtitle">
<a class="thumbnailLink" href="{{ page.permalink }}"
>{{ page.title }}</a
Expand Down