test(s3): simplify s3 configurations#919
Merged
andrewazores merged 5 commits intocryostatio:mainfrom Jun 12, 2025
Merged
Conversation
andrewazores
force-pushed
the
s3-smoketest-config
branch
from
f1af2a0 to
597568e
Compare
Member
Author
|
/build_test |
|
Workflow started at 5/16/2025, 11:05:57 AM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ |
Josh-Matsuoka
approved these changes
Jun 11, 2025
andrewazores
force-pushed
the
s3-smoketest-config
branch
from
c55dce0 to
2e9e871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to cryostatio/cryostat-helm#247
Description of the change:
While working on the linked Helm issue and using the smoketest S3 configurations as references, I noticed that things could be cleaned up.
There is no need to explicitly set
QUARKUS_S3_AWS_CREDENTIALS_TYPE=static, since the default value isdefaultand uses a strategy of checking various provider sources, including the static provider. The static provider looks for a few options such as a home directory config file, as well as the already existingAWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYenvironment variables.Also,
cloudserverwas missing a healthcheck definition which caused it to fail to start.How to manually test:
./smoketest.bash -s {provider}, whereprovideris one ofseaweed,localstack,cloudserver, orminio(ie. any of thes3-*.ymlcompose files)