Big Refactor According to Updated Spec#44
Open
XuJiandong wants to merge 3 commits intocryptape:mainfrom
Open
Conversation
XuJiandong
changed the title
Reference C implementation: nervosnetwork/omnilock#3 Changes: - add lazy reader support - API changed - add testing - add documents. make it ready for publishing - fix according to updated spec - add logs
* Add testcases, about cobuild_normal_entry * Add some cycles checks for normal and successful cases.
|
Just a quick glance at this PR: I could get the underlying change, but at this stage, I wasn't so sure about the API change, where we moved completely into a callback based design, instead of Rust iterators. I fear this might be far too big a change. Even if we switch from current design to a lazy loader based design, I feel like we can still keep much of the current APIs, yes there might be one or two data structure change but that will pretty much be it. I wonder if we need to completely overhaul this, especially when the updated API, looks quite messy to me. |
|
I do recommend that we split it into 3 smaller PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference C implementation: nervosnetwork/omnilock#3
Changes:
Note to reviewers:
i,j,ie,oeare from spec