-
Notifications
You must be signed in to change notification settings - Fork 6
fix(AlertDialog): no actions state #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 62ba3ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for cube-uikit-docs failed.
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-41c70f3. |
🏗 Docs are successfully deployed!👀 Preview: https://684020fae127e03252efd9ff--cube-uikit-docs.netlify.app |
🧪 Storybook is successfully deployed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to fix the rendering behavior of the AlertDialog by modifying the condition that determines whether the Footer should be rendered. Key changes include:
- Updating the conditional expression controlling footer rendering in AlertDialog.tsx.
- Adjusting the changeset documentation to reflect the intended behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/overlays/AlertDialog/AlertDialog.tsx | Updated the condition for rendering the footer section |
| .changeset/proud-suits-raise.md | Added a changeset note to explain the footer rendering fix |
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
No description provided.