Skip to content

fix(AlertDialog): no actions state #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025
Merged

fix(AlertDialog): no actions state #689

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddb88f4
fix(AlertDialog): no actions state
tenphi Jun 4, 2025
25d313c
Update src/components/overlays/AlertDialog/AlertDialog.tsx
tenphi Jun 4, 2025
62ba3ce
Update .changeset/proud-suits-raise.md
tenphi Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/proud-suits-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Do not render the footer in AlertDialog if all button props are falsy'
26 changes: 14 additions & 12 deletions src/components/overlays/AlertDialog/AlertDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,20 +82,22 @@ function AlertDialog(props: CubeAlertDialogProps, ref) {
)}
</Content>
) : null}
{!noActions ? (
{!noActions || (!confirmProps && !secondaryProps && !cancelProps) ? (
<Footer>
<ButtonGroup align="end">
<Button
autoFocus
theme={danger ? 'danger' : undefined}
{...confirmProps}
onPress={(e) =>
chain(
(confirmProps as CubeButtonProps)?.onPress?.(e),
onClose?.('confirm'),
)
}
/>
{confirmProps && (
<Button
autoFocus
theme={danger ? 'danger' : undefined}
{...confirmProps}
onPress={(e) =>
chain(
(confirmProps as CubeButtonProps)?.onPress?.(e),
onClose?.('confirm'),
)
}
/>
)}
{secondaryProps && (
<Button
{...secondaryProps}
Expand Down
Loading