fix(ComboBox): qa prop #832
Conversation
🦋 Changeset detectedLatest commit: 9d9ec23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
📦 NPM canary releaseDeployed canary version 0.0.0-canary-9533b02. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| <InputElement | ||
| ref={combinedRef} | ||
| qa="Input" | ||
| qa={qa} |
There was a problem hiding this comment.
Bug: ComboBox Input QA Prop Inheritance Issue
The InputElement within ComboBox no longer defaults to qa="Input". Instead, its qa prop is directly set from the ComboBox's qa prop, which can be undefined. This removes a consistent identifier for the input field, breaking existing QA selectors and making it harder to target the input for testing.
| > | ||
| {prefix ? <div data-element="Prefix">{prefix}</div> : null} | ||
| <ComboBoxInput | ||
| qa={qa} |
There was a problem hiding this comment.
Bug: ComboBox QA Prop Misrouting
The qa prop on ComboBox no longer customizes the ComboBoxWrapperElement, which now uses a hardcoded qa='ComboBoxWrapper'. The component's qa prop is instead passed to the InputElement, potentially leaving its qa attribute undefined. This breaks QA selector customization for both the wrapper and the input.
| data-size={size} | ||
| {...compositeFocusProps} | ||
| > | ||
| {prefix ? <div data-element="Prefix">{prefix}</div> : null} |
There was a problem hiding this comment.
Bug: ComboBox Wrapper QA Attribute Overwritten
The ComboBoxWrapperElement now has a hardcoded qa attribute, preventing the qa prop from the ComboBox component from customizing the root wrapper's QA identifier. It always defaults to 'ComboBoxWrapper'.
Additional Locations (1)
🧪 Storybook is successfully deployed!
|
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Note
Forward qa to the ComboBox input, set a default qa on the wrapper, and remove unused props from ComboBoxInput.
src/components/fields/ComboBox/ComboBox.tsx):qato the input element (replaces hardcoded"Input").qaonComboBoxWrapperElementand stop passingqaat usage.isLoadingandallowsCustomValuefromComboBoxInputprops.Written by Cursor Bugbot for commit 6960a12. This will update automatically on new commits. Configure here.