Skip to content

fix: Simplify external refresh condition so when pre-aggregation buil… #10116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
+3 −4
Merged

fix: Simplify external refresh condition so when pre-aggregation buil… #10116

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c465f7
fix: Simplify external refresh condition so when pre-aggregation buil…
paveltiunov Nov 5, 2025
0dea2a3
Fix tests should be in production mode
paveltiunov Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/cubejs-server-core/src/core/OptsHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,10 +686,7 @@ export class OptsHandler {
clone.preAggregationsOptions.externalRefresh =
clone.preAggregationsOptions.externalRefresh !== undefined
? clone.preAggregationsOptions.externalRefresh
: (
!this.isPreAggsBuilder() ||
clone.rollupOnlyMode && !this.configuredForScheduledRefresh()
);
: !this.isPreAggsBuilder();

clone.preAggregationsOptions.maxPartitions =
clone.preAggregationsOptions.maxPartitions !== undefined
Expand Down
Loading