Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Nov 5, 2025

…der is set so it's never an external refresh instance

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

…der is set so it's never an external refresh instance
@paveltiunov paveltiunov requested a review from a team as a code owner November 5, 2025 17:59
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.13%. Comparing base (e9dce76) to head (0dea2a3).
⚠️ Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e9dce76) and HEAD (0dea2a3). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e9dce76) HEAD (0dea2a3)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10116       +/-   ##
===========================================
- Coverage   83.33%   55.13%   -28.20%     
===========================================
  Files         244      213       -31     
  Lines       74112    16885    -57227     
  Branches        0     3330     +3330     
===========================================
- Hits        61763     9310    -52453     
+ Misses      12349     7099     -5250     
- Partials        0      476      +476     
Flag Coverage Δ
cube-backend 55.13% <ø> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paveltiunov paveltiunov merged commit 4f4a0b4 into master Nov 5, 2025
72 of 73 checks passed
@paveltiunov paveltiunov deleted the simplify-external-refresh-condition branch November 5, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants