Skip to content

perf(schema-compiler): Optimize CubeToMetaTransformer compilation flow #10150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

perf(schema-compiler): Optimize CubeToMetaTransformer compilation flow #10150

wants to merge 11 commits into from
+627 −436

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 18, 2025 •
edited
Loading

This PR is actually a side effect of the other stuff I'm working on :) But, well, why not improve some things here, too! :)

This PR brings some performance improvements in the CubeToMetaTransformer compilation flow:

  • increase compilation speed
  • reduce memory allocations
  • reduce memory pressure for GC

And finally, CubeToMetaTransformer and some other minor classes were moved to TypeScript!

Some confirmation pictures :)

Memory allocations BEFORE:
Screenshot 2025-11-18 в 20 32 03

Memory allocations AFTER:
Screenshot 2025-11-18 в 20 32 13

CPU FlameGraph BEFORE:
Screenshot 2025-11-18 в 20 33 36

CPU FlameGraph AFTER:
Screenshot 2025-11-18 в 20 33 49

Check List

  • Tests have been run in packages where changes have been made, if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 18, 2025
@KSDaemon KSDaemon force-pushed the feat/meta-transformer-improve branch from a69214a to 06128c1 Compare November 18, 2025 18:42
@KSDaemon KSDaemon force-pushed the feat/meta-transformer-improve branch from 06128c1 to 6230419 Compare November 18, 2025 19:02
@codecov
Copy link

codecov bot commented Nov 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.11382% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.74%. Comparing base (258be19) to head (3f677f0).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ema-compiler/src/compiler/CubeToMetaTransformer.ts 81.25% 10 Missing and 8 partials ⚠️
...s-schema-compiler/src/compiler/ContextEvaluator.ts 83.33% 1 Missing and 1 partial ⚠️
...ejs-schema-compiler/src/compiler/CubeDictionary.ts 87.50% 1 Missing ⚠️
...cubejs-schema-compiler/src/compiler/CubeSymbols.ts 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (258be19) and HEAD (3f677f0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (258be19) HEAD (3f677f0)
cubesql 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #10150       +/-   ##
===========================================
- Coverage   83.29%   54.74%   -28.55%     
===========================================
  Files         244      213       -31     
  Lines       74180    16945    -57235     
  Branches        0     3366     +3366     
===========================================
- Hits        61786     9277    -52509     
+ Misses      12394     7181     -5213     
- Partials        0      487      +487
Flag Coverage Δ
cube-backend 54.74% <82.11%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review November 18, 2025 21:29
@KSDaemon KSDaemon requested a review from a team as a code owner November 18, 2025 21:29
ovr
ovr reviewed Nov 19, 2025
View reviewed changes
ovr
ovr reviewed Nov 19, 2025
View reviewed changes
@KSDaemon KSDaemon force-pushed the feat/meta-transformer-improve branch from ece328c to 3f677f0 Compare November 21, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovr ovr ovr approved these changes

Assignees

No one assigned

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KSDaemon @ovr