-
Notifications
You must be signed in to change notification settings - Fork 1.9k
perf(schema-compiler): Optimize CubeToMetaTransformer compilation flow #10150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KSDaemon
wants to merge
11
commits into
master
Choose a base branch
from
feat/meta-transformer-improve
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
339aea6
get rid of ramda in CubeToMetaTransformer
KSDaemon ed4bff7
optimize transform() in CubeToMetaTransformer
KSDaemon 4008594
move CubeDictionary to ts
KSDaemon f71c752
some types specified (CompilerInterface)
KSDaemon 614e31d
move ContextEvaluator to ts
KSDaemon 12fdff1
fix unit tests (because of types)
KSDaemon 52c529f
more precise types in CubeSymbols
KSDaemon a3664bb
fix integration tests (because of types)
KSDaemon 6230419
move CubeToMetaTransformer to ts
KSDaemon dca7c96
rewrite byId in CubeDictionary to Map<string, Cube>
KSDaemon ece328c
move contextDefinitions in ContextEvaluator to Map<string, CompiledCo…
KSDaemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 0 additions & 35 deletions
35
packages/cubejs-schema-compiler/src/compiler/ContextEvaluator.js
This file was deleted.
Oops, something went wrong.
47 changes: 47 additions & 0 deletions
47
packages/cubejs-schema-compiler/src/compiler/ContextEvaluator.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import type { CubeEvaluator } from './CubeEvaluator'; | ||
| import type { ErrorReporter } from './ErrorReporter'; | ||
| import { CompilerInterface } from './PrepareCompiler'; | ||
|
|
||
| export interface ContextInput { | ||
| name: string; | ||
| contextMembers: any; | ||
| } | ||
|
|
||
| export interface CompiledContext { | ||
| name: string; | ||
| contextMembers: any; | ||
| } | ||
|
|
||
| export class ContextEvaluator implements CompilerInterface { | ||
| private cubeEvaluator: CubeEvaluator; | ||
|
|
||
| private contextDefinitions: Record<string, CompiledContext>; | ||
|
|
||
| public constructor(cubeEvaluator: CubeEvaluator) { | ||
| this.cubeEvaluator = cubeEvaluator; | ||
| this.contextDefinitions = {}; | ||
| } | ||
|
|
||
| public compile(contexts: ContextInput[], _errorReporter?: ErrorReporter): void { | ||
| if (contexts.length === 0) { | ||
| return; | ||
| } | ||
|
|
||
| // TODO: handle duplications, context names must be uniq | ||
| this.contextDefinitions = {}; | ||
| for (const context of contexts) { | ||
| this.contextDefinitions[context.name] = this.compileContext(context); | ||
| } | ||
| } | ||
|
|
||
| private compileContext(context: ContextInput): CompiledContext { | ||
| return { | ||
| name: context.name, | ||
| contextMembers: this.cubeEvaluator.evaluateReferences(null, context.contextMembers) | ||
| }; | ||
| } | ||
|
|
||
| public get contextList(): string[] { | ||
| return Object.keys(this.contextDefinitions); | ||
| } | ||
| } | ||
20 changes: 0 additions & 20 deletions
20
packages/cubejs-schema-compiler/src/compiler/CubeDictionary.js
This file was deleted.
Oops, something went wrong.
31 changes: 31 additions & 0 deletions
31
packages/cubejs-schema-compiler/src/compiler/CubeDictionary.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import type { ErrorReporter } from './ErrorReporter'; | ||
| import { TranspilerCubeResolver } from './transpilers'; | ||
| import { CompilerInterface } from './PrepareCompiler'; | ||
|
|
||
| export interface Cube { | ||
| name: string; | ||
| [key: string]: any; | ||
| } | ||
|
|
||
| export class CubeDictionary implements TranspilerCubeResolver, CompilerInterface { | ||
| public byId: Record<string, Cube>; | ||
|
|
||
| public constructor() { | ||
| this.byId = {}; | ||
KSDaemon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| public compile(cubes: Cube[], _errorReporter?: ErrorReporter): void { | ||
| this.byId = {}; | ||
| for (const cube of cubes) { | ||
| this.byId[cube.name] = cube; | ||
| } | ||
| } | ||
|
|
||
| public resolveCube(name: string): boolean { | ||
| return !!this.byId[name]; | ||
| } | ||
|
|
||
| public free(): void { | ||
| this.byId = {}; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.