Skip to content

Conversation

@morgan-at-cube
Copy link
Contributor

@morgan-at-cube morgan-at-cube commented May 9, 2024

Add warning box to two pages: Please note that Redshift does not support intervals of type month or year.

Context: https://cubedevinc.slack.com/archives/C021C7NT7RT/p1715293531642229

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

Please note that Redshift does not support intervals of type month or year.
@vercel
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 11:15pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 11:15pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 11:15pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 11:15pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 11:15pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 11:15pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 11:15pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 11:15pm

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label May 9, 2024
Please note that Redshift does not support intervals of type month or year.
Comment on lines +20 to +25
<WarningBox>

Please note that Redshift does not support intervals of type month or year.

</WarningBox>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morgan-at-cube I don't think we need to put this warning on this particular page. If we do, then we'd probably need to have it at every page mentioning rolling_window which is probably not the way to go.

Comment on lines +260 to +265
<WarningBox>

Please note that Redshift does not support intervals of type month or year.

</WarningBox>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morgan-at-cube Do we know how it breaks? E.g., what is the exact error message?

I think we can probably do the following:

  • Add the error message and the note on the Redshift data source page.
  • Have a more generic note on this page, e.g., "There are known limitations for rolling_window support when using Redhsift (link to the data source page)". It's gonna be more extendable this way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @igorlukanin , getting back to you about this has been in my to-do list for ages, sorry about that! I don't have the error message unfortunately :( Do you think we can still add a generic error message to this page anyway?

@igorlukanin igorlukanin self-assigned this Nov 22, 2024
@igorlukanin igorlukanin added the docs Issues that require a documentation improvement label Nov 22, 2024
@KSDaemon
Copy link
Member

KSDaemon commented Jun 2, 2025

I think this is obsolete because of #9489

@morgan-at-cube
Copy link
Contributor Author

I think this is obsolete because of #9489

Cool, thanks!

@morgan-at-cube morgan-at-cube deleted the patch-18 branch June 9, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues that require a documentation improvement pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants