Skip to content

Warn in rolling window pages that Redshift does not support month or year intervals #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Warn in rolling window pages that Redshift does not support month or year intervals #8252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c60d45
Update measures.mdx
morgan-at-cube May 9, 2024
88aa949
Update period-over-period.mdx
morgan-at-cube May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/pages/guides/recipes/data-modeling/period-over-period.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ _previous period_.
these `rolling_window` measures and uses them in a calculation, e.g.,
divides or subtracts them.

<WarningBox>

Please note that Redshift does not support intervals of type month or year.

</WarningBox>

Comment on lines +20 to +25
Copy link
Member

@igorlukanin igorlukanin Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morgan-at-cube I don't think we need to put this warning on this particular page. If we do, then we'd probably need to have it at every page mentioning rolling_window which is probably not the way to go.

The following data model allows to calculate a month-over-month change of
some value. `current_month_sum` and `previous_month_sum` measures define
two rolling windows and the `month_over_month_ratio` measure divides
Expand Down Expand Up @@ -89,4 +95,4 @@ Here's the result:

[ref-rolling-window]: /reference/data-model/measures#rolling_window
[ref-calculated-measure]: /product/data-modeling/overview#4-using-calculated-measures
[ref-time-dimension-granularity]: /product/apis-integrations/rest-api/query-format#time-dimensions-format
[ref-time-dimension-granularity]: /product/apis-integrations/rest-api/query-format#time-dimensions-format
6 changes: 6 additions & 0 deletions docs/pages/reference/data-model/measures.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,12 @@ with a defined date range.

</WarningBox>

<WarningBox>

Please note that Redshift does not support intervals of type month or year.

</WarningBox>

Comment on lines +260 to +265
Copy link
Member

@igorlukanin igorlukanin Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morgan-at-cube Do we know how it breaks? E.g., what is the exact error message?

I think we can probably do the following:

  • Add the error message and the note on the Redshift data source page.
  • Have a more generic note on this page, e.g., "There are known limitations for rolling_window support when using Redhsift (link to the data source page)". It's gonna be more extendable this way.

Copy link
Contributor Author

@morgan-at-cube morgan-at-cube Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @igorlukanin , getting back to you about this has been in my to-do list for ages, sorry about that! I don't have the error message unfortunately :( Do you think we can still add a generic error message to this page anyway?

These parameters have a format defined as
`(-?\d+) (minute|hour|day|week|month|year)`. The `trailing` and `leading`
parameters can also be set to an `unbounded` value, which means infinite size
Expand Down