Skip to content

Conversation

@cpcpn-emil
Copy link
Contributor

@cpcpn-emil cpcpn-emil commented Aug 30, 2024

Closes #8641

Description of Changes Made (if issue reference is not provided)

Simply lowercase the search to remain consistent in the implementation

@cpcpn-emil cpcpn-emil requested a review from a team as a code owner August 30, 2024 12:56
@vercel
Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 0:57am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 0:57am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 0:57am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 0:57am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 0:57am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 0:57am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 0:57am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 0:57am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Aug 30, 2024
@cpcpn-emil
Copy link
Contributor Author

@paveltiunov Do I need to make further changes to this PR?

@paveltiunov
Copy link
Member

@cpcpn-emil Thanks for contributing! We'd need a test please! 🙏

@cpcpn-emil
Copy link
Contributor Author

@cpcpn-emil Thanks for contributing! We'd need a test please! 🙏

Hi, no problem.
I assume the change to packages/cubejs-druid-driver/test/druid-query.test.ts is not enough?
Would you expect a new test case in druid-query.test.ts ?

@igorlukanin
Copy link
Member

@cpcpn-emil Having a new test would be perfect since the existing ones weren't able to catch the defect in question in the first place.

@igorlukanin igorlukanin added the driver:druid Issues relating to the Druid driver label Sep 30, 2024
@KSDaemon KSDaemon changed the title Druid case sensitivity fix fix(druid-driver): Fix case sensitivity in like flow Jan 17, 2025
@KSDaemon KSDaemon merged commit 6d75c60 into cube-js:master Jan 17, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

driver:druid Issues relating to the Druid driver pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Druid db filtering: case insensitive bug

4 participants