Skip to content

fix(druid-driver): Fix case sensitivity in like flow #8658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2025
Merged

fix(druid-driver): Fix case sensitivity in like flow #8658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f458c7c
Update the likeIgnoreCase method for the druid driver
cpcpn-emil Aug 30, 2024
a89f8ad
Update test
cpcpn-emil Aug 30, 2024
de7ee0c
Merge branch 'master' into druid_case_sensitivity_fix
KSDaemon Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cubejs-druid-driver/src/DruidQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ class DruidFilter extends BaseFilter {
public likeIgnoreCase(column, not, param, type: string) {
const p = (!type || type === 'contains' || type === 'ends') ? '%' : '';
const s = (!type || type === 'contains' || type === 'starts') ? '%' : '';
return `${column}${not ? ' NOT' : ''} LIKE CONCAT('${p}', ${this.allocateParam(param)}, '${s}')`;
return `LOWER(${column})${not ? ' NOT' : ''} LIKE CONCAT('${p}', LOWER(${this.allocateParam(param)}), '${s}')`;
}
}

export class DruidQuery extends BaseQuery {
public newFilter(filter) {
return new DruidFilter(this, filter);
}

public timeGroupedColumn(granularity: string, dimension: string) {
return GRANULARITY_TO_INTERVAL[granularity](dimension);
}
Expand Down
4 changes: 2 additions & 2 deletions packages/cubejs-druid-driver/test/druid-query.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('DruidQuery', () => {
type: 'time',
}
}

})
`, {});

Expand All @@ -54,7 +54,7 @@ describe('DruidQuery', () => {
},
);
const queryAndParams = query.buildSqlAndParams();
expect(queryAndParams[0]).toContain('LIKE CONCAT(\'%\', ?, \'%\'))');
expect(queryAndParams[0]).toContain('LIKE CONCAT(\'%\', LOWER(?), \'%\'))');
}));

it('druid query timezone shift test', () => compiler.compile().then(() => {
Expand Down
Loading