fix(schema-compiler): Use segments as-is in rollupPreAggregation #9391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcheshkov
force-pushed
the
rollup-preagg-segment-member-expression
branch
2 times, most recently
from
dc439dd to
a3f6592
Compare
mcheshkov
changed the title
waralexrom
approved these changes
Apr 1, 2025
mcheshkov
force-pushed
the
rollup-preagg-segment-member-expression
branch
from
a3f6592 to
be6bf96
Compare
This is to support member expression segments, as BaseFilter does not expect member expressions in it, i.e. in `filterToWhere` is always call `dimensionSql`
mcheshkov
force-pushed
the
rollup-preagg-segment-member-expression
branch
from
be6bf96 to
2644284
Compare
marianore-muttdata
pushed a commit
to MuttData/cube
that referenced
this pull request
Jun 17, 2025
…e-js#9391) This is to support member expression segments, as BaseFilter does not expect member expressions in it, i.e. in `filterToWhere` is always call `dimensionSql`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
This is to support member expression segments, as BaseFilter does not expect member expressions in it, i.e. in
filterToWhereis always calldimensionSql