-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(schema-compiler): Use LRUCache for js data models compiled vm.Scripts #9424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
de6e653 to
d1ff8c8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9424 +/- ##
===========================================
- Coverage 83.75% 47.91% -35.84%
===========================================
Files 229 171 -58
Lines 82747 21338 -61409
Branches 0 3691 +3691
===========================================
- Hits 69305 10225 -59080
+ Misses 13442 10678 -2764
- Partials 0 435 +435
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ovr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, don't forget to release on shutdown.
ae25475 to
efd95f9
Compare
…ripts (cube-js#9424) * fix types * update lru-cache to the latest * fix lru-cache after upgrade * introduce compiledScriptCache * add proactive cache cleanup * call compilerCache.clear() on shutdown
This introduces an LRU cache for storing compiled versions of JS data model transpiled files. It improves compilation performance.
Check List