Skip to content

Conversation

@mcheshkov
Copy link
Contributor

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Without this when following from view to cube member join hints will be collected and ignored, then join hints would be collected for references from cube member to other cube members, and only those would be used for join tree

@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.87%. Comparing base (4d1b17a) to head (16f97de).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...cubejs-schema-compiler/src/compiler/CubeSymbols.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4d1b17a) and HEAD (16f97de). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4d1b17a) HEAD (16f97de)
cubesql 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9444       +/-   ##
===========================================
- Coverage   83.91%   47.87%   -36.04%     
===========================================
  Files         229      171       -58     
  Lines       83657    21422    -62235     
  Branches        0     3712     +3712     
===========================================
- Hits        70197    10255    -59942     
+ Misses      13460    10730     -2730     
- Partials        0      437      +437     
Flag Coverage Δ
cube-backend 47.87% <50.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcheshkov mcheshkov marked this pull request as ready for review April 9, 2025 10:32
@mcheshkov mcheshkov requested a review from a team as a code owner April 9, 2025 10:32
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM! Really clear and self-explanatory tests with comments! Thank you!

…itself owned

Without this when following from view to cube member join hints will be collected and ignored, then join hints would be collected for references from cube members to other cube members, and only those would be used for join tree
@mcheshkov mcheshkov force-pushed the views-references-join-hints branch from d3948c9 to 16f97de Compare April 10, 2025 17:46
@mcheshkov mcheshkov merged commit b5ddd11 into master Apr 10, 2025
68 checks passed
@mcheshkov mcheshkov deleted the views-references-join-hints branch April 10, 2025 18:26
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
…itself owned (cube-js#9444)

Without this when following from view to cube member join hints will be collected and ignored, then join hints would be collected for references from cube members to other cube members, and only those would be used for join tree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants