Skip to content

Conversation

@KSDaemon
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.04%. Comparing base (409d74d) to head (990e54f).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-server/src/websocket-server.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9458      +/-   ##
==========================================
- Coverage   48.05%   48.04%   -0.01%     
==========================================
  Files         171      171              
  Lines       21453    21455       +2     
  Branches     3722     3723       +1     
==========================================
  Hits        10309    10309              
- Misses      10712    10714       +2     
  Partials      432      432              
Flag Coverage Δ
cube-backend 48.04% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review April 11, 2025 18:34
@KSDaemon KSDaemon requested a review from a team as a code owner April 11, 2025 18:34
Copy link
Contributor

@mcheshkov mcheshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly is better then before
But I hope we can get it to better state son soon

@KSDaemon KSDaemon force-pushed the fix/ws-native-result-wrapper branch from c47b4a9 to e75b2ee Compare April 11, 2025 18:44
@KSDaemon KSDaemon force-pushed the fix/ws-native-result-wrapper branch from e75b2ee to 990e54f Compare April 11, 2025 18:50
@KSDaemon KSDaemon merged commit a4e76c4 into master Apr 11, 2025
30 checks passed
@KSDaemon KSDaemon deleted the fix/ws-native-result-wrapper branch April 11, 2025 19:21
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants