Skip to content

fix(server): Fix incorrect native result wrapper processing via webSockets #9458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

fix(server): Fix incorrect native result wrapper processing via webSockets #9458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/cubejs-server/src/websocket-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,14 @@
// it again - it's too expensive, instead we serialize the rest of the message and then
// inject query result json into message.
const resMsg = new TextDecoder().decode(await message.message.getFinalResult());
message.message = '~XXXXX~';
delete message.message;

Check warning on line 46 in packages/cubejs-server/src/websocket-server.ts

View check run for this annotation

Codecov / codecov/patch

packages/cubejs-server/src/websocket-server.ts#L46 

Added line #L46 was not covered by tests
messageStr = JSON.stringify(message);
messageStr = messageStr.replace('"~XXXXX~"', resMsg);

if (messageStr === '{}') {
messageStr = `{"message":${resMsg}}`;

Check warning on line 50 in packages/cubejs-server/src/websocket-server.ts

View check run for this annotation

Codecov / codecov/patch

packages/cubejs-server/src/websocket-server.ts#L50 

Added line #L50 was not covered by tests
} else {
messageStr = `${messageStr.slice(0, -1)},"message":${resMsg}}`;

Check warning on line 52 in packages/cubejs-server/src/websocket-server.ts

View check run for this annotation

Codecov / codecov/patch

packages/cubejs-server/src/websocket-server.ts#L52 

Added line #L52 was not covered by tests
}
} else {
messageStr = JSON.stringify(message);
}
Expand Down