Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jul 7, 2025

  • update data model scheme for calendar time shifts + compilation tests
  • chore(tesseract): Refactoring of time shift without time dimension logic
  • add timeshift definitions to rust side
  • implement time shifts over calendar tables

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (93a4dcb) to head (f3c874d).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9758      +/-   ##
==========================================
+ Coverage   84.25%   84.26%   +0.01%     
==========================================
  Files         231      232       +1     
  Lines       85650    86447     +797     
==========================================
+ Hits        72163    72845     +682     
- Misses      13487    13602     +115     
Flag Coverage Δ
cubesql 84.26% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review July 9, 2025 17:34
@KSDaemon KSDaemon requested a review from a team as a code owner July 9, 2025 17:34
@KSDaemon KSDaemon merged commit 70dfa52 into master Jul 9, 2025
82 checks passed
@KSDaemon KSDaemon deleted the feat/calendar-timeshifts branch July 9, 2025 17:48
Frank-TXS pushed a commit to Helge-TXS/cube that referenced this pull request Aug 5, 2025
…ns (cube-js#9758)

* update data model scheme for calendar time shifts + compilation tests

* chore(tesseract): Refactoring of time shift without time dimension logic

* add timeshift definitions to rust side

* implement time shifts over calendar tables

* add usefull comment

* fix correct sql gen for calendar custom gran but with common timeshift

* add tests

---------

Co-authored-by: Alexandr Romanenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants