Skip to content

Implement HookDefinition.getHookType and unimplement Location.getLocation #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

Implement HookDefinition.getHookType and unimplement Location.getLocation #402

merged 3 commits into from
Jul 23, 2025

Conversation

gaeljw
Copy link
Member

@gaeljw gaeljw commented Jul 23, 2025 •
edited
Loading

Solves #401

The only impact for users is in the output in case of errors, there can be a bit more noise to identify the root cause line:

- ScalaDslStepsTest.scala:68
+ io.cucumber.scala.ScalaDslStepsTest$Glue$3.<init>(ScalaDslStepsTest.scala:68)

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@gaeljw gaeljw changed the title chore: implement getHookType on ScalaHookDefinition Implement HookDefinition.getHookType and unimplement Location.getLocation Jul 23, 2025
@gaeljw gaeljw marked this pull request as ready for review July 23, 2025 09:56
@gaeljw gaeljw linked an issue Jul 23, 2025 that may be closed by this pull request
Implement HookDefinition.getHookType and unimplement Location.getLocation #401
Closed
mpkorstanje
mpkorstanje approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're happy with the slightly noisier output I'm happy. If not, then I can workaround it for the regression tests.

LGTM

@gaeljw gaeljw merged commit c219bd5 into main Jul 23, 2025
4 of 5 checks passed
@gaeljw gaeljw deleted the gh401 branch July 23, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpkorstanje mpkorstanje mpkorstanje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement HookDefinition.getHookType and unimplement Location.getLocation
2 participants
@gaeljw @mpkorstanje