Upgrade MessagePack to v3 to support AOT#117
Open
asus4 wants to merge 4 commits intocuriosity-ai:masterfrom
Open
Upgrade MessagePack to v3 to support AOT#117asus4 wants to merge 4 commits intocuriosity-ai:masterfrom
asus4 wants to merge 4 commits intocuriosity-ai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @theolivenbaum, Thank you for open-sourcing this library. It helps porting Python-based NLP to C#!
Key changes in this PR:
MessagePackpackage to v3 to ensure it works on the AOT required environment (Unity / Xamarin)Details
I'm using Catalyst in Unity. It worked perfectly on Windows and macOS, but when running it in IL2CPP environments like iOS, I get the following error when calling
await Pipeline.ForAsync(Mosaik.Core.Language.English);. This can be resolved by upgrading to MessagePack v3, which generates AOT-compatible source code via source generators.Error log on iOS
(Here's a Kokoro TTS demo utilizing Catalyst for NLP)
2025-04-17-kokoro.mp4